Skip to content

mainnet: update task 005 to executed status, add tx hash#124

Merged
maurelian merged 2 commits intomainfrom
mds1-patch-1
Apr 3, 2024
Merged

mainnet: update task 005 to executed status, add tx hash#124
maurelian merged 2 commits intomainfrom
mds1-patch-1

Conversation

@mds1
Copy link
Copy Markdown
Contributor

@mds1 mds1 commented Apr 3, 2024

This looks like the correct transaction based on it's calldata: https://etherscan.io/tx/0x29bb617fac8f49f5c934cc776b22d47e187ab482e86f21e4502a23ba1c9ad0da

First decoding the data from the root level input data

$ cast 4byte-decode 0x82ad56cb00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000001000000000000000000000000008062abc286f5e7d9428a0ccb9abd71e50d93b9350000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000245fd579af0000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008062abc286f5e7d9428a0ccb9abd71e50d93b9350000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000240457d6f2000000000000000000000000000000000000000600000000000000000000000000000000000000000000000000000000000000000000000000000000
1) "aggregate3((address,bool,bytes)[])"
[(0x8062AbC286f5e7D9428a0Ccb9AbD71e50d93b935, false, 0x5fd579af0000000000000000000000000000000000000006000000000000000000000000), (0x8062AbC286f5e7D9428a0Ccb9AbD71e50d93b935, false, 0x0457d6f20000000000000000000000000000000000000006000000000000000000000000)]

Then decoding each of the separate data fields:

$ cast 4byte-decode 0x5fd579af0000000000000000000000000000000000000006000000000000000000000000
1) "setRecommended(uint256)"
475368975085586025561263702016 [4.753e29]
$ cast 4byte-decode 0x0457d6f20000000000000000000000000000000000000006000000000000000000000000
1) "setRequired(uint256)"
475368975085586025561263702016 [4.753e29]

@mds1 mds1 requested review from maurelian and zchn as code owners April 3, 2024 18:57
maurelian
maurelian previously approved these changes Apr 3, 2024
This playbook was a contingency for the highly unlikely emergency that we need to quickly switch batch sending
back to calldata. This playbook was not needed and therefore is now cancelled
@maurelian maurelian added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 2dbfe46 Apr 3, 2024
@maurelian maurelian deleted the mds1-patch-1 branch April 3, 2024 19:08
jcortejoso pushed a commit to celo-org/superchain-ops that referenced this pull request Jun 11, 2025
…imism#124)

* Split script between frontier chain and standard chain.

* Split .env.example.

* Update CONTRIBUTING.md

* Fix broken link.

* fix heading

---------

Co-authored-by: Kevin Kz <k@oplabs.co>
github-merge-queue Bot pushed a commit that referenced this pull request Jan 16, 2026
* test: add post task assertions (#111)

* test: update configs with soneium (#81)

* fix: forge fmt (#84)

* test: add post task assertions

* style: formatting

* test: receive assertions vars from env

* refactor: remove trycatch usage

* fix: build error (#88)

* fix: warning

* chore: sync prod configs (#94)

* feat: base as executed (#1312)

* feat:add worldchain sepolia key handback over task (#1284)

* feat:add worldchain sepolia key handback over task

* clean up worldchain key handback over task

* changed worldchain task number

* fix:delete task 39

replaced by task 46

* fix:update nonces

* Update src/tasks/sep/046-worldchain-l2pao-key-handback-over/README.md

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* fix:updated message hashes

changed after adding new nonces

* Update README.md

* fix:clean up text in sepolia validation.md

* Update src/tasks/sep/046-worldchain-l2pao-key-handback-over/VALIDATION.md

Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>

* ci: bump timeout because stacked sims are slow

* ci: this really shouldn’t take 90m, testing…

* Update config.toml

* Update config.yml

* feat: nonce bump

* fix: remove noGasMetering modifier which causes stacked sims to hang

I am unsure exactly why it hangs. This did not used to hang, but now it does.
Still need to better understand the root cause here

---------

Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Co-authored-by: JosepBove <josep@oplabs.co>

* Safer safes migrate to LivenessModule2 template (#1298)

* WIP on jb/safer-safes

* fix: typos

* feat: regression tests and finish template

* fmt

* fix: block

* adding solutions to sepolia task dir (#1306)

* feat: set worldchain l2pao key handback as executed on sepolia (#1315)

* test: update configs with soneium (#81) (#1309)

* test: update configs with soneium (#81)

* fix: forge fmt (#84)

* fix: build error (#88)

* fix: warning

* fix: wrong sepolia examples tasks numeration

---------

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>

---------

Co-authored-by: JosepBove <josep@oplabs.co>
Co-authored-by: Zak Ayesh <44901995+ZakAyesh@users.noreply.github.com>
Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com>
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>

* refactor: consistency in integration tests structure

* test: remove min withdrawal check

* test: add post task assertions example command

* test: expect l1withdrawer address on expect emit

* refactor: change hardcoded variables to environment

* refactor: move reused code to internal integration base functions

* chore: update tasks config values

* fix: remove wrong config

* feat: add production task (#98)

* test: add L2ToL1 message relaying

* test: use fusaka block numbers and update regression tests

* fix: sep task order on name

* fix: integration and stack simulate tests (#100)

* test: update tests

* test: use deployed contracts upgrader

* chore: remove unused vars

* chore: remove unused vars

* fix: update message hashes

* fix: reduce upgrade gas limit (#102)

* chore: update gas limit on examples as well

* chore: improve L1 RPC example

* test: add L1ToL2 message relaying

* fix: sep council msg hash based on stacked simulation (#103)

* fix: recipient in OP after FeesDepositor deposit

* fix: add nonce overrides in sepolia task, fix hash in eth task (#106)

* fix: remove pao nonce update on 048 and msg hashes (#107)

* chore: increase gas cost on message relaying

* fix: wrong address for TransactionDeposited event

---------

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Co-authored-by: JosepBove <josep@oplabs.co>
Co-authored-by: Zak Ayesh <44901995+ZakAyesh@users.noreply.github.com>
Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com>

* fix: op fork id

* refactor: improve assertions (#119)

* fix: query l1 withdrawer instead of calculating it

* fix: remove mainnet from op url name since it can be testnet as well

* refactor: improve withdrawal assertions using below and above threshold

* fix: receive op cdm as input instead of hardcoding mainnet

* fix: rounding error on assertion

* chore: replace mainnet hardcoded values for env inputs

* chore: create strcuts to organize inputs and remove some mainnet defaults

* chore: polish

* chore: sync assertions (#120)

* ci: update mention from evm-safety-team to security-oncall (#1328)

* Update U18 betanet tasks addresses (#1329)

* Update U18 betanet tasks addresses

* Update addresses and hashes

* Update U18 beta task status (#1331)

Update U18 beta task status

* ci/fix: add lint rule to detect non-alphabetical struct field ordering in TOML/JSON parsing (#1335)

* ci: add script and check for proper struct ordering

* fix: struct field ordering in OPCMUpgradeV600

* test: fix regression test, calldata changed

* chore: revert chmod change

---------

Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com>

* Revert "chore: sync assertions (#120)"

This reverts commit db61257.

* Merge pull request #124 from defi-wonderland/chore/improve-example-args

chore: improve example args

* Merge pull request #129 from defi-wonderland/fix/address-comments

fix: address comments

---------

Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Co-authored-by: JosepBove <josep@oplabs.co>
Co-authored-by: Zak Ayesh <44901995+ZakAyesh@users.noreply.github.com>
Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com>
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants