Feat/mcp: implement post check script by 0xfuturistic · Pull Request #119 · ethereum-optimism/superchain-ops

0xfuturistic · 2024-03-30T23:34:39Z

Closes https://github.com/ethereum-optimism/security-pod/issues/98

tynes · 2024-04-01T16:10:10Z

If we added a pre hook to go with the post hook then it would work really well with the state diff recording cheatcodes. Thoughts @mds1 @maurelian ?

tynes · 2024-04-01T16:10:25Z

We should add assertions that any address referenced has code

Co-authored-by: Matt Solomon <matt@mattsolomon.dev>

…for MCP

tynes · 2024-04-05T20:47:46Z

I don't see the following log printed:
console.log("Running post-deploy assertions");

Are we sure the post check is running in CI?

0xfuturistic · 2024-04-05T20:48:39Z

I don't see the following log printed: console.log("Running post-deploy assertions");

Are we sure the post check is running in CI?

@mds1 is working on adding _postCheck() to method signJson here

tynes · 2024-04-05T21:05:57Z

The failure is

    ├─ [672] 0x229047fed2591dbec1eF1118d64F7aF3dB9EB290::startBlock() [staticcall]

We should double check the implementation of the system config that is upgraded to has startBlock in its abi

* test: add post task assertions (#111) * test: update configs with soneium (#81) * fix: forge fmt (#84) * test: add post task assertions * style: formatting * test: receive assertions vars from env * refactor: remove trycatch usage * fix: build error (#88) * fix: warning * chore: sync prod configs (#94) * feat: base as executed (#1312) * feat:add worldchain sepolia key handback over task (#1284) * feat:add worldchain sepolia key handback over task * clean up worldchain key handback over task * changed worldchain task number * fix:delete task 39 replaced by task 46 * fix:update nonces * Update src/tasks/sep/046-worldchain-l2pao-key-handback-over/README.md Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * fix:updated message hashes changed after adding new nonces * Update README.md * fix:clean up text in sepolia validation.md * Update src/tasks/sep/046-worldchain-l2pao-key-handback-over/VALIDATION.md Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> * ci: bump timeout because stacked sims are slow * ci: this really shouldn’t take 90m, testing… * Update config.toml * Update config.yml * feat: nonce bump * fix: remove noGasMetering modifier which causes stacked sims to hang I am unsure exactly why it hangs. This did not used to hang, but now it does. Still need to better understand the root cause here --------- Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: Matt Solomon <matt@mattsolomon.dev> Co-authored-by: JosepBove <josep@oplabs.co> * Safer safes migrate to LivenessModule2 template (#1298) * WIP on jb/safer-safes * fix: typos * feat: regression tests and finish template * fmt * fix: block * adding solutions to sepolia task dir (#1306) * feat: set worldchain l2pao key handback as executed on sepolia (#1315) * test: update configs with soneium (#81) (#1309) * test: update configs with soneium (#81) * fix: forge fmt (#84) * fix: build error (#88) * fix: warning * fix: wrong sepolia examples tasks numeration --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> --------- Co-authored-by: JosepBove <josep@oplabs.co> Co-authored-by: Zak Ayesh <44901995+ZakAyesh@users.noreply.github.com> Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: Matt Solomon <matt@mattsolomon.dev> Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com> Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * refactor: consistency in integration tests structure * test: remove min withdrawal check * test: add post task assertions example command * test: expect l1withdrawer address on expect emit * refactor: change hardcoded variables to environment * refactor: move reused code to internal integration base functions * chore: update tasks config values * fix: remove wrong config * feat: add production task (#98) * test: add L2ToL1 message relaying * test: use fusaka block numbers and update regression tests * fix: sep task order on name * fix: integration and stack simulate tests (#100) * test: update tests * test: use deployed contracts upgrader * chore: remove unused vars * chore: remove unused vars * fix: update message hashes * fix: reduce upgrade gas limit (#102) * chore: update gas limit on examples as well * chore: improve L1 RPC example * test: add L1ToL2 message relaying * fix: sep council msg hash based on stacked simulation (#103) * fix: recipient in OP after FeesDepositor deposit * fix: add nonce overrides in sepolia task, fix hash in eth task (#106) * fix: remove pao nonce update on 048 and msg hashes (#107) * chore: increase gas cost on message relaying * fix: wrong address for TransactionDeposited event --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: JosepBove <josep@oplabs.co> Co-authored-by: Zak Ayesh <44901995+ZakAyesh@users.noreply.github.com> Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: Matt Solomon <matt@mattsolomon.dev> Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com> * fix: op fork id * refactor: improve assertions (#119) * fix: query l1 withdrawer instead of calculating it * fix: remove mainnet from op url name since it can be testnet as well * refactor: improve withdrawal assertions using below and above threshold * fix: receive op cdm as input instead of hardcoding mainnet * fix: rounding error on assertion * chore: replace mainnet hardcoded values for env inputs * chore: create strcuts to organize inputs and remove some mainnet defaults * chore: polish * chore: sync assertions (#120) * ci: update mention from evm-safety-team to security-oncall (#1328) * Update U18 betanet tasks addresses (#1329) * Update U18 betanet tasks addresses * Update addresses and hashes * Update U18 beta task status (#1331) Update U18 beta task status * ci/fix: add lint rule to detect non-alphabetical struct field ordering in TOML/JSON parsing (#1335) * ci: add script and check for proper struct ordering * fix: struct field ordering in OPCMUpgradeV600 * test: fix regression test, calldata changed * chore: revert chmod change --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev> Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com> * Revert "chore: sync assertions (#120)" This reverts commit db61257. * Merge pull request #124 from defi-wonderland/chore/improve-example-args chore: improve example args * Merge pull request #129 from defi-wonderland/fix/address-comments fix: address comments --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: JosepBove <josep@oplabs.co> Co-authored-by: Zak Ayesh <44901995+ZakAyesh@users.noreply.github.com> Co-authored-by: Wazabie <48911235+Wazabie@users.noreply.github.com> Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: Alberto Cuesta Cañada <38806121+alcueca@users.noreply.github.com> Co-authored-by: Matt Solomon <matt@mattsolomon.dev> Co-authored-by: soyboy <85043086+sbvegan@users.noreply.github.com>

0xfuturistic requested a review from tynes March 30, 2024 23:34

0xfuturistic requested review from a team, maurelian, mds1 and zchn as code owners March 30, 2024 23:34

zchn assigned mds1 and unassigned mds1 Mar 31, 2024

tynes reviewed Apr 1, 2024

View reviewed changes