feat: L2 call via portal template#1231
Merged
blmalone merged 30 commits intoOct 1, 2025
Merged
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
blmalone
reviewed
Sep 25, 2025
Contributor
blmalone
left a comment
blmalone
left a comment
There was a problem hiding this comment.
It's looking good! one q about the inheritance.
Contributor
|
@0xiamflux this is looking good, one more comment then we can merge this. Also can you rebase with |
Co-authored-by: 0xOneTony <112496816+0xOneTony@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
0xiamflux
force-pushed
the
sc-feat/l2-call-via-portal-template
branch
from
e33b1aa to
8a225bb
Compare
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
fix: portal from value change allowlist, remove value natspec ref
blmalone
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/improvements/template/L1PortalExecuteL2Call.solIOptimismPortal2(depositTransaction) to dispatch an L2 call from an L1 Safeconfig.toml:portal,l2Target,l2Data,gasLimit(uint64),isCreation(default false)SimpleTaskBasefor L1 multisig flows;safeAddressString()defaults toProxyAdminOwnerOptimismPortalTests