feat: add L1PortalExecuteL2Call template for L2 actions through OptimismPortal by 0xiamflux · Pull Request #1173 · ethereum-optimism/superchain-ops

0xiamflux · 2025-08-28T17:22:30Z

Description

Add L1→L2 portal execution template
- src/improvements/template/L1PortalExecuteL2Call.sol
- Uses full IOptimismPortal2 (depositTransaction) to dispatch an L2 call from an L1 Safe
- Config-driven params via config.toml: portal, l2Target, l2Data, gasLimit (uint64), value (default 0), isCreation (default false)
- Extends SimpleTaskBase for L1 multisig flows; safeAddressString() defaults to ProxyAdminOwner
- Validation: asserts exactly one portal call with expected calldata/value; allowlists storage/balance changes for OptimismPortal
Add full portal interface
- src/improvements/interfaces/IOptimismPortal.sol (complete IOptimismPortal2)
Scaffold nested rehearsal task
- src/improvements/tasks/eth/rehearsals/2025-08-11-l1-to-l2-noop/
- config.toml placeholders and signer README.md with simulate/validate/sign steps

Tests

Template-level validation enforces encoded calldata and a single portal action
Manual simulate run expected:
- Tenderly diff: no unintended changes; shows portal call and event emission

Co-authored-by: 0xOneTony <112496816+0xOneTony@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>

Rehearsal: Governor Upgrade on L2 via Optimism Portal

graphite-app · 2025-08-28T18:20:20Z

+
+# Portal + L2 call params
+portal = "0xbEb5Fc579115071764c7423A4f12eDde41f106Ed" # L1 OptimismPortal
+l2Target = "0x1234567890123456789012345678901234567890" # replace with real OptimismGovernor Proxy


The placeholder address 0x1234567890123456789012345678901234567890 should be replaced with the actual OptimismGovernor Proxy address on L2 before using this configuration for the rehearsal. Using a real address ensures that the simulation and validation steps will accurately reflect the intended behavior when executed on-chain.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-08-28T18:20:22Z

+# Portal + L2 call params
+portal = "0xbEb5Fc579115071764c7423A4f12eDde41f106Ed" # L1 OptimismPortal
+l2Target = "0x1234567890123456789012345678901234567890" # replace with real OptimismGovernor Proxy
+l2Data = "0x3659cfe60000000000000000000000000000000000000000000000000000000000001234" # upgradeTo(0x00..1234)


The placeholder address 0x00..1234 in the L2Data is not a valid implementation address for a production deployment. For a proper rehearsal, consider replacing this with either:

The current implementation address (for a true no-op upgrade)

A valid implementation contract address that exists on L2

This ensures the rehearsal accurately simulates a real governance action. The test example in 014-noop-call-optimismportal demonstrates this approach by using the current implementation address.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

blmalone · 2025-08-29T15:29:42Z

@@ -0,0 +1,265 @@
+# Rehearsal 4 - No-op Governor Upgrade


Why is this being put into the rehearsals directory?

GM, our goal here was to add a rehearsal task for a no-op upgrade on the Optimism Governor Proxy on L2 using a newly added template. What would be the best place to do this?

hm, this rehearsals directory contains templates and ceremonies related to onboarding Security Council members. I don't think this is what you want to do right?

The task was to create a rehearsal upgrade ceremony for the Security Council to complete an end-to-end process of a no-op upgrade in a way that is repeatable.

Which would be a better suited place to put it?

Is this simply to test this templates functionality? Or have you been in touch with the security council and agreed that this should be a new rehearsal for them to perform when onboarding a security council memeber?

If it's the former, you don't need to add this as a rehearsal. When you create a new template, you just need to follow this guide: https://github.com/ethereum-optimism/superchain-ops/blob/main/src/improvements/doc/NEW_TEMPLATE_GUIDE.md (1. make template 2. make Regression test 3. make example task

We just removed the rehearsal docs in the rehearsal folder on this commit.

blmalone · 2025-09-17T13:54:25Z

+import {Action} from "../../libraries/MultisigTypes.sol";
+
+import {IOptimismPortal2} from "lib/optimism/packages/contracts-bedrock/interfaces/L1/IOptimismPortal2.sol";
+


Suggested change

Addressed here.

blmalone · 2025-09-17T14:03:37Z

+    }
+
+    /// @notice Validate that exactly one action to the portal with the expected calldata and value was captured.
+    function _validate(VmSafe.AccountAccess[] memory, Action[] memory _actions, address) internal override {


Suggested change

function _validate(VmSafe.AccountAccess[] memory, Action[] memory _actions, address) internal override {

function _validate(VmSafe.AccountAccess[] memory, Action[] memory _actions, address) internal view override {

Addressed here.

blmalone · 2025-09-17T14:13:07Z

+    /// @notice Build the portal deposit action. WARNING: State changes here are reverted after capture.
+    function _build(address) internal override {
+        // Record the L1 portal call with value for action extraction.
+        IOptimismPortal2(portal).depositTransaction{value: valueWei}(l2Target, valueWei, gasLimit, isCreation, l2Data);


does this need to take a value? I'm curious as I don't think we've fully tested if the value actually gets transferred.

For the particular use case we had in mind when adding the template it does not need the value, but I think for a general purpose solution is good to have it there. What would be the proper way to fully test and document this?

Can you hardcode 0 for this first version?

When performing an upgrade action i.e. portal.depositTransaction, this function is executed inside a Multicall3 contract. The safe delegatecall's to the Multicall3 contract. Right now, this will fail because of the require check inside the Multicall3 contract: https://github.com/mds1/multicall3/blob/main/src/Multicall3.sol#L160 (see: stackexchange)

Addressed in here.

got it, do you want to close this PR in favor of #1231?

graphite-app · 2025-09-18T20:24:38Z

+        IOptimismPortal2(portal).depositTransaction{value: valueWei}(l2Target, valueWei, gasLimit, isCreation, l2Data);
+    }
+
+    /// @notice Validate that exactly one action to the portal with the expected calldata and value was captured.


The _validate function is missing natspec documentation. According to the Solidity Guide, functions should use triple-slash natspec comment style with @notice tags instead of single-line comments. Replace the single-line comment with proper natspec documentation using /// @notice.

Spotted by Diamond (based on custom rule: Custom rules)

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-09-18T20:24:40Z

+        MultisigTaskPrinter.printTitle("Validated portal deposit action");
+    }
+
+    /// @notice No code exceptions required for this template.


The _getCodeExceptions function is missing natspec documentation. According to the Solidity Guide, functions should use triple-slash natspec comment style with @notice tags instead of single-line comments. Replace the single-line comment with proper natspec documentation using /// @notice.

Spotted by Diamond (based on custom rule: Custom rules)

Is this helpful? React 👍 or 👎 to let us know.

mds1 · 2025-09-19T18:54:54Z

 ## Creating and signing a new rehearsal ceremony

 To create a new rehearsal ceremony, follow the instructions in the _Facilitator_ section of the README files for each of the following rehearsals:
+


nit, can undo this diff since we don't touch the rehearsals dir anywhere else here

mds1 · 2025-09-19T18:58:17Z

+import {VmSafe} from "forge-std/Vm.sol";
+import {stdToml} from "forge-std/StdToml.sol";
+
+import {IOptimismPortal2} from "lib/optimism/packages/contracts-bedrock/interfaces/L1/IOptimismPortal2.sol";


Instead of importing the interface, let's define the relevant interface in this file with interface IOptimismPortal2 { ... }. The reason for this is so that, in the future, the template can keep working for chains running older versions of the OP stack, even if the monorepo submodule version is bumped. In other words, we don't want templates to suddenly break when we bump the submodule version (i.e. if we change the portal interface in the future) because not all chains are necessarily on the latest version at all times, so we prefer to make sure templates continue to work

mds1 · 2025-09-19T19:04:02Z

+    // -------- Config inputs --------
+    address payable public portal; // L1 OptimismPortal address
+    address public l2Target; // L2 target address
+    bytes public l2Data; // Inner L2 calldata


nit, just to be more precise, assuming this is correct

Suggested change

bytes public l2Data; // Inner L2 calldata

bytes public l2Data; // Inner L2 calldata, i.e. the calldata to execute on `l2Target`

mds1 · 2025-09-19T19:05:47Z

+
+        isCreation = false;
+        try vm.parseTomlBool(_toml, ".isCreation") returns (bool _b) {
+            isCreation = _b;


The portal has this check so it's arguably unnecessary, but might be better UX to check and revert here if isCreation && l2Target != address(0). Up to you

I do like this, makes sense to early revert before reaching the portal.

mds1 · 2025-09-19T19:11:17Z

+        // Resolve portal from registry first if available, else read explicit field.
+        try simpleAddrRegistry.get("OptimismPortal") returns (address p) {
+            portal = payable(p);
+        } catch {
+            portal = payable(_toml.readAddress(".portal"));
+        }


For the revshare use case, it might be better UX (fewer playbooks, fewer signatures) to have this template support doing a deposit transaction for many L2s in the same transaction. In that case, we would want to inherit from L2TaskBas instead and have the config inputs be arrays corresponding to the deposit. What do you think here?

Do you think it makes sense to have 2 separate templates one for simpler use cases and the other for multi chain calls?

As we continued working on the Rev Share use case, we have came to the conclusion it should have it’s own, separate template and we can keep this as a general purpose template for more simple cases. Wdyt?

Having a separate template is good with me!

mds1 · 2025-09-19T19:12:25Z

+        // Read hex string and parse to bytes.
+        string memory _dataHex = _toml.readString(".l2Data");
+        l2Data = vm.parseBytes(_dataHex);
+        require(l2Data.length > 0, "l2Data must be set");


Could just do _toml.readBytes here

mds1 · 2025-09-19T19:13:43Z

+        bytes memory _expected = abi.encodeWithSelector(
+            IOptimismPortal2.depositTransaction.selector, l2Target, valueWei, gasLimit, isCreation, l2Data
+        );


nit, prefer abi.encodeCall

mds1 · 2025-09-19T19:16:28Z

This task was recently changed to CANCELLED so we should be able to undo the diff in this task's dir

…sCreation=true

graphite-app · 2025-09-23T13:41:05Z

+contract L1PortalExecuteL2Call is SimpleTaskBase {
+    using stdToml for string;
+
+    // -------- Config inputs --------


The comment // -------- Config inputs -------- should use triple-slash Solidity NatSpec format: /// -------- Config inputs -------- per the Solidity style guide requirements.

Suggested change

// -------- Config inputs --------

/// -------- Config inputs --------

Spotted by Diamond (based on custom rule: Custom rules)

Is this helpful? React 👍 or 👎 to let us know.

0xiamflux · 2025-09-25T17:22:21Z

Continue review in #1231, leaving this open for now for future reference.

oxlumi and others added 11 commits August 19, 2025 11:48

chore: add remapping for optimism lib

289bdd4

feat: L1PortalExecuteL2Call task implementation

fb1de79

feat: rehearsals specs for L1PortalExecuteL2Call task

27de7e3

test: add regression test for new template L1PortalExecuteL2Call

64e7689

feat: create new rehearsal ceremony to make an upgrade to L2 Governor

a4bc70d

chore: update comment on Optimism Portal address

0f97595

Co-authored-by: 0xOneTony <112496816+0xOneTony@users.noreply.github.com> Signed-off-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>

Merge pull request #2 from defi-wonderland/test/l1portalexecutel2call

dfadb1f

Rehearsal: Governor Upgrade on L2 via Optimism Portal

chore: sync with main branch

9b22137

refactor: remove nested try-catch

212a84e

chore: update fmt

fe44a7e

chore: complies with ci

b823c6a

0xiamflux requested review from a team as code owners August 28, 2025 17:22

0xiamflux requested a review from mds1 August 28, 2025 17:22

0xiamflux mentioned this pull request Aug 28, 2025

feat: show L2 calls made through portal ethereum-optimism/op-txverify#24

Merged

graphite-app Bot reviewed Aug 28, 2025

View reviewed changes

blmalone reviewed Aug 29, 2025

View reviewed changes

chore: remove unecessary remapping

a9b18e6

blmalone reviewed Sep 17, 2025

View reviewed changes

0xiamflux added 3 commits September 18, 2025 14:43

chore: remove rehearsal docs for no-op upgrade

51d63c5

chore: fix compiler warnings

543b409

chore: fix just simulate sep command failure

cc569d3

graphite-app Bot reviewed Sep 18, 2025

View reviewed changes

mds1 reviewed Sep 19, 2025

View reviewed changes

0xiamflux added 8 commits September 22, 2025 10:14

chore: remove newline in sc rehearsals README

fcc89ba

refactor: add OptimismPortal interface in template to avoid coupling

fadfa08

chore: update comment natspec on template

a3ca79e

feat: revert before reaching portal with a descriptive message when i…

0caf083

…sCreation=true

refactor: prefe readBytes over manually parsing

c0cd688

fix: use encodeCall over encodeWithSelector

0af20c9

chore: undo diff for canceled task

cde2b35

chore: fix README newlines

3f3b8d9

graphite-app Bot reviewed Sep 23, 2025

View reviewed changes

0xOneTony force-pushed the sc-feat/l1portalexecutel2call-template branch from d26ced1 to 3f3b8d9 Compare September 23, 2025 18:15

0xiamflux mentioned this pull request Sep 25, 2025

chore: Fixes defi-wonderland/superchain-ops#14

Merged

0xiamflux closed this Oct 2, 2025

0xiamflux deleted the sc-feat/l1portalexecutel2call-template branch October 9, 2025 15:32

		import {Action} from "../../libraries/MultisigTypes.sol";

		import {IOptimismPortal2} from "lib/optimism/packages/contracts-bedrock/interfaces/L1/IOptimismPortal2.sol";

	function _validate(VmSafe.AccountAccess[] memory, Action[] memory _actions, address) internal override {
	function _validate(VmSafe.AccountAccess[] memory, Action[] memory _actions, address) internal view override {

		## Creating and signing a new rehearsal ceremony

		To create a new rehearsal ceremony, follow the instructions in the _Facilitator_ section of the README files for each of the following rehearsals:

	bytes public l2Data; // Inner L2 calldata
	bytes public l2Data; // Inner L2 calldata, i.e. the calldata to execute on `l2Target`

	// -------- Config inputs --------
	/// -------- Config inputs --------

Conversation

0xiamflux commented Aug 28, 2025

Description

Tests

Uh oh!

graphite-app Bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mds1 Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Sep 23, 2025

Choose a reason for hiding this comment

mds1 Sep 19, 2025 •

edited

Loading