feat: add shared lockbox spec #465
Merged
smartcontracts merged 21 commits intoethereum-optimism:mainfrom Feb 26, 2025
Merged
Conversation
* feat: add shared lockbox spec * feat: update shared lockbox spec * fix: specs * feat: add mermaid diagram * fix: prs comments * fix: nits * fix: remove dependency manager * feat: refactor lockbox specs * fix: nit * fix: misspellings * fix: verb tense * fix: prs comments * fix: small changes
agusduha
requested review from
ajsutton,
mslipper,
protolambda,
sebastianst and
tynes
as code owners
tynes
reviewed
Nov 27, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
maurelian
reviewed
Dec 11, 2024
tynes
reviewed
Dec 11, 2024
tynes
reviewed
Dec 11, 2024
tynes
reviewed
Dec 11, 2024
ControlCplusControlV
left a comment
ControlCplusControlV
left a comment
There was a problem hiding this comment.
Left some minor comments, but overall looks great!
Contributor
|
Dropping this comment here as per request from @tynes. I think the most valuable think to add to this PR would be to clearly define the invariants that need to be maintained when we introduce this component. Some examples here would be:
I think point (3) is the most important and it would be valuable to explore all of the ways in which this condition could be violated. What is "safe"? We need to be exhaustive. |
tynes
reviewed
Dec 17, 2024
tynes
reviewed
Dec 17, 2024
* feat: add shared lockbox invariants * fix: remove immutable variable * feat: add upgrader role * feat: add authorized invariants to the portal * fix: pr * fix: add upgrader role and remove new portal invariants
ControlCplusControlV
left a comment
ControlCplusControlV
left a comment
There was a problem hiding this comment.
some small comments / nits but it looks great overall!
mds1
reviewed
Feb 26, 2025
mds1
reviewed
Feb 26, 2025
mds1
reviewed
Feb 26, 2025
mds1
reviewed
Feb 26, 2025
mds1
reviewed
Feb 26, 2025
mds1
reviewed
Feb 26, 2025
mds1
approved these changes
Feb 26, 2025
Contributor
mds1
left a comment
mds1
left a comment
There was a problem hiding this comment.
All comments are small and easy to fix, so approving
smartcontracts
approved these changes
Feb 26, 2025
protolambda
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing the
SharedLockboxspec and its corresponding upgrade process. This enhancement improves the Superchain’s interoperable ETH withdrawal user experience and prevents withdrawal failures caused by insufficient ETH in theOptimismPortal.Additional context
Design doc: ethereum-optimism/design-docs#206