feat: Add new FMA Shared Lockbox#193
Merged
mds1 merged 16 commits intoethereum-optimism:mainfrom Feb 10, 2025
Merged
Conversation
mds1
reviewed
Jan 29, 2025
mds1
reviewed
Jan 29, 2025
Contributor
|
This looks pretty thorough to me |
tynes
reviewed
Jan 30, 2025
tynes
reviewed
Jan 30, 2025
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
mds1
reviewed
Jan 30, 2025
JosepBove
reviewed
Jan 31, 2025
JosepBove
reviewed
Jan 31, 2025
mds1
reviewed
Jan 31, 2025
Contributor
Author
|
After reviewing the latest Shared Lockbox design, the decision has been made to remove the feature that allowed adding a new chain via an upgrade initiated from L2. This change has been reflected in the code, and I will update this doc as well. |
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
mds1
reviewed
Feb 10, 2025
mds1
approved these changes
Feb 10, 2025
Contributor
mds1
left a comment
mds1
left a comment
There was a problem hiding this comment.
Also needs approval from @smartcontracts before merging
smartcontracts
approved these changes
Feb 10, 2025
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the FMA for the new Shared Lockbox design.
Additional context
Below are the references for this project:
It replaces the previous FMA, which can be found here for reference.