Merged
Conversation
clabby
requested review from
ajsutton,
protolambda and
sebastianst
as code owners
clabby
force-pushed
the
cl/clarify-1559-config
branch
from
99d7abe to
c4def72
Compare
sebastianst
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the configurable EIP-1559 parameters spec for Holocene. Previously, we specified using the EIP-1559 parameters passed through the payload for the current block. However, this poses a problem in most eth clients, where the next block's base fee is computed as a pure function, just taking in the current timestamp + parent block header.
With this change, the current block's EIP-1559 parameters after Holocene are determined from the parent header's nonce field. In practice, this means that updates to the EIP-1559 parameters activate 1 block after they are first included in the
PayloadAttributesV3, rather than immediately.