Remove auto-publishing on develop; add canary tool #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
snario
commented
May 25, 2021
|
|
||
| on: | ||
| # enable users to manually trigger with workflow_dispatch | ||
| workflow_dispatch: {} |
There was a problem hiding this comment.
snario
commented
May 25, 2021
Comment on lines
+53
to
+54
| yarn changeset version --snapshot | ||
| yarn changeset publish --tag canary |
There was a problem hiding this comment.
snario
commented
May 25, 2021
| @@ -3,7 +3,6 @@ name: Release | |||
| on: | |||
| push: | |||
| branches: | |||
| - develop | |||
There was a problem hiding this comment.
After this, we will only publish real versions once we merge to master like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does two things:
developnpmversions and Docker images at a snapshot given a branch. For example:0.0.0-canary-127312312may be the tag name for every package.(1) solves the issue of us needing to make changes to our code before we merge to
master, which is true "stable" branch. (2) gives us the tool we need once (1) is done to still be able to test onk8sand other production-like environments.