fix[contracts]: remove upgrade cancellation functions#904
Merged
smartcontracts merged 3 commits intoregenesis/0.4.0from May 19, 2021
Merged
fix[contracts]: remove upgrade cancellation functions#904smartcontracts merged 3 commits intoregenesis/0.4.0from
smartcontracts merged 3 commits intoregenesis/0.4.0from
Conversation
🦋 Changeset detectedLatest commit: 300af04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## v0.4.0-rc #904 +/- ##
=============================================
- Coverage 85.37% 85.29% -0.08%
=============================================
Files 51 51
Lines 1962 1952 -10
Branches 315 314 -1
=============================================
- Hits 1675 1665 -10
Misses 287 287
Continue to review full report at Codecov.
|
Contributor
|
This needs to re-target |
smartcontracts
requested review from
K-Ho,
annieke,
karlfloersch and
tynes
as code owners
ben-chain
approved these changes
May 19, 2021
Collaborator
ben-chain
left a comment
ben-chain
left a comment
There was a problem hiding this comment.
LGTM, agree this is the way to go.
gakonst
pushed a commit
that referenced
this pull request
May 20, 2021
* fix[contracts]: remove upgrade cancellation functions * chore: add changeset * Update L2ChugSplashDeployer.sol
gakonst
pushed a commit
that referenced
this pull request
May 21, 2021
* fix[contracts]: remove upgrade cancellation functions * chore: add changeset * Update L2ChugSplashDeployer.sol
smartcontracts
added a commit
that referenced
this pull request
May 30, 2021
* fix[contracts]: remove upgrade cancellation functions * chore: add changeset * Update L2ChugSplashDeployer.sol
ben-chain
pushed a commit
to ben-chain/optimism
that referenced
this pull request
Jun 23, 2021
…ism#904) * fix[contracts]: remove upgrade cancellation functions * chore: add changeset * Update L2ChugSplashDeployer.sol
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
cancelTransactionBundleandoverrideTransactionBundlefunctions fromL2ChugSplashDeployer.Please see this issue for additional context: #894