Skip to content

Comments

feat[contracts]: add ability to pause EM during upgrades#892

Merged
smartcontracts merged 4 commits intoregenesis/0.4.0from
kelvin/pause-em-during-upgrade
May 20, 2021
Merged

feat[contracts]: add ability to pause EM during upgrades#892
smartcontracts merged 4 commits intoregenesis/0.4.0from
kelvin/pause-em-during-upgrade

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented May 17, 2021

Description
Adds a flag that will cause the EM to redirect all transactions to the L2ChugSplashDeployer while an upgrade is active. Makes sure that we won't have any weird behavior while an upgrade is in progress.

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4f9c95f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@smartcontracts smartcontracts changed the base branch from develop to v0.4.0-rc May 17, 2021 19:47
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #892 (4f9c95f) into regenesis/0.4.0 (4866d7b) will decrease coverage by 0.16%.
The diff coverage is 56.25%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           regenesis/0.4.0     #892      +/-   ##
===================================================
- Coverage            85.76%   85.59%   -0.17%     
===================================================
  Files                   51       52       +1     
  Lines                 1967     1986      +19     
  Branches               317      320       +3     
===================================================
+ Hits                  1687     1700      +13     
- Misses                 280      286       +6
Impacted Files Coverage Δ
...ic-ethereum/OVM/execution/OVM_ExecutionManager.sol 72.64% <0.00%> (-1.40%) ⬇️
...acts/contracts/chugsplash/L2ChugSplashDeployer.sol 100.00% <100.00%> (ø)
...tic-ethereum/OVM/predeploys/OVM_GasPriceOracle.sol 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4866d7b...4f9c95f. Read the comment docs.

@smartcontracts smartcontracts mentioned this pull request May 17, 2021
Closed
@smartcontracts
Copy link
Contributor Author

smartcontracts commented May 18, 2021 •
edited
Loading

Note: this PR needs tests

@snario
Copy link
Contributor

snario commented May 19, 2021

This needs to re-target regenesis/0.4.0.

@smartcontracts smartcontracts marked this pull request as ready for review May 19, 2021 18:05
@smartcontracts smartcontracts force-pushed the kelvin/pause-em-during-upgrade branch from ffc9eb7 to d75d3da Compare May 19, 2021 19:49
ben-chain
ben-chain approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@ben-chain ben-chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be shipped as-is, but left a couple notes for consideration. 👍

@gakonst gakonst force-pushed the regenesis/0.4.0 branch from 2487238 to 7dc0f7e Compare May 20, 2021 10:17
@gakonst gakonst force-pushed the regenesis/0.4.0 branch 2 times, most recently from 68e161a to 4866d7b Compare May 20, 2021 10:54
@gakonst gakonst force-pushed the kelvin/pause-em-during-upgrade branch from d75d3da to 9a1bd5a Compare May 20, 2021 13:26
@gakonst
Copy link
Contributor

gakonst commented May 20, 2021

Rebased on top of regenesis/0.4.0.

maurelian
maurelian requested changes May 20, 2021
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I made any comments that necessitate changes, but think they should be considered before merging.

maurelian
maurelian approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional comments. LGTM.

@smartcontracts smartcontracts merged commit 7f7806c into regenesis/0.4.0 May 20, 2021
@smartcontracts smartcontracts deleted the kelvin/pause-em-during-upgrade branch May 20, 2021 18:51
gakonst pushed a commit that referenced this pull request May 21, 2021
@smartcontracts @gakonst
feat[contracts]: add ability to pause EM during upgrades (#892)
466827d 
* wip: start work on pausing em during upgrade

* fix: execution manager gas test

* test: add tests for deployer fallback

* add some additional comments
smartcontracts added a commit that referenced this pull request May 30, 2021
@smartcontracts
feat[contracts]: add ability to pause EM during upgrades (#892)
e0397a8 
* wip: start work on pausing em during upgrade

* fix: execution manager gas test

* test: add tests for deployer fallback

* add some additional comments
ben-chain pushed a commit to ben-chain/optimism that referenced this pull request Jun 23, 2021
@smartcontracts @ben-chain
feat[contracts]: add ability to pause EM during upgrades (ethereum-op…
6b1c320 
…timism#892)

* wip: start work on pausing em during upgrade

* fix: execution manager gas test

* test: add tests for deployer fallback

* add some additional comments
theochap pushed a commit that referenced this pull request Dec 10, 2025
@emhane
chore(deps): Replace dep alloy-rs/op-alloy-registry->`op-rs/maili-r…
84645d3 
…egistry` (#892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-chain ben-chain ben-chain approved these changes

@maurelian maurelian maurelian approved these changes

@annieke annieke Awaiting requested review from annieke

@elenadimitrova elenadimitrova Awaiting requested review from elenadimitrova

@karlfloersch karlfloersch Awaiting requested review from karlfloersch

@tynes tynes Awaiting requested review from tynes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@smartcontracts @codecov-commenter @snario @gakonst @ben-chain @maurelian