Update op-geth dependency to upstream geth v1.13.8 and migrate to slog#8917
Update op-geth dependency to upstream geth v1.13.8 and migrate to slog#8917sebastianst merged 34 commits intodevelopfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8917 +/- ##
===========================================
+ Coverage 16.57% 24.62% +8.04%
===========================================
Files 119 104 -15
Lines 5098 3732 -1366
Branches 1130 536 -594
===========================================
+ Hits 845 919 +74
+ Misses 4178 2767 -1411
+ Partials 75 46 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Looks like the logging changes bit us. |
|
Semgrep found 10
Named return arguments to functions must be appended with an underscore ( Semgrep found 39
Prefer |
6c1072c to
83caf39
Compare
sebastianst
left a comment
There was a problem hiding this comment.
Left a couple of pointers for reviewers.
e865bd9 to
23453cb
Compare
commit fb90ca39bc5c4f45e99ef320abfab85eeb56c561
520cc52 to
e7fd916
Compare
|
Semgrep found 7
Found banned use of |
trianglesphere
left a comment
There was a problem hiding this comment.
Some small comments, but nothing big.
protolambda
left a comment
There was a problem hiding this comment.
Changes LGTM. A few imports seem to need lint fixes, specifically for "golang.org/x/exp/slog" in a few places
Description
Updated op-geth dependency to ethereum-optimism/op-geth#215 based on upstream geth v1.13.8
Also migrates logging infra to slog, after upstream migrated to slog in ethereum/go-ethereum#28187.
I opened an upstream PR to add the
Handlergetter to theLoggerinterface (slog'sLoggerinterface itself has this getter). It's already in the op-geth version that this PR is based on.Metadata