Conversation
Update optimism dependency version Group rvgo tests into package
ajsutton
approved these changes
Feb 7, 2024
Collaborator
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
LGTM. Just added a couple of notes about related PRs.
clabby
approved these changes
Feb 7, 2024
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
This looks good to me. Approving pending the monorepo changes being merged + updating the dependency :)
Apply logging changes Update op-geth version
Collaborator
Author
|
@ajsutton Thank you for the updates about Canon changes. I have updated optimism dependency to the latest develop branch and applied log library changes and blob preimage key handling. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement Asterisc binary with Cannon-compatible commands:
load-elfwitnessrunAlmost every code is based on Cannon's implementation with minor fixes.
If the codes are related to VM or its other functionalities, I just copied and reused those codes from Cannon to minimize dependencies on Cannon and keep it as an alternative implementation. Otherwise if the codes are just utilities unrelated to VM, they are imported as dependencies.
For the special case, flags of each command are directly imported from Cannon as a dependency because the interface of Asterisc binary must be compatible with Cannon for op-challenger integration.
This PR depends on modification on Optimism monorepo(ethereum-optimism/optimism#9350). The dependency is temporarily set to the working branch for now, and it will be changed to the develop branch once the optimism PR is merged.
Tests
Tested each command for
minimal.go. More test cases could be added in future PRs, and this may be further tested and modified as we work on the op-challenger integration.