feat(op-challenger): Output Bisection Game Genesis Output Root Fetching

[refcell]

Descriptions

Adds support for genesis output root fetching to the op-challenger contracts.

Metadata

Makes progress on https://github.com/ethereum-optimism/client-pod/issues/259

[coderabbitai]

Walkthrough

Walkthrough

The recent updates to the op-challenger codebase involve structural changes to fault handling and contract interaction. New validation methods and types have been introduced, shifting some functionality from interfaces to function types. The OutputBisectionGameContract now includes a method for retrieving the genesis output root, and associated tests have been added. These changes enhance the code's modularity and extend its capabilities for handling game states and blockchain interactions.

Changes

File(s)	Summary
.../fault/register.go	Consolidated changes to add validateAbsolutePrestate method to outputAlphabetResources and outputCannonResources and modified CreateAccessor to include this method as a parameter.
.../fault/trace/outputs/output_alphabet.go, .../fault/trace/outputs/output_cannon.go	Added a new parameter v of type AbsolutePrestateValidator to accessor functions and included conditional validation logic.
.../fault/trace/outputs/provider.go	Introduced a new type alias AbsolutePrestateValidator for a validation function.
.../fault/contracts/outputbisectiongame.go (2 entries)	Added a new global variable methodGenesisOutputRoot and a new method GetGenesisOutputRoot to OutputBisectionGameContract.
.../fault/player.go	Changed PrestateLoader from an interface to a function type.
.../fault/player_test.go	Modified newMockPrestateLoader to return a function instead of a struct.
.../fault/contracts/outputbisectiongame_test.go	Added a new test function TestGetGenesisOutputRoot to verify the new contract method.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[refcell]

Current dependencies on/for this PR:

• develop
  • PR feat(op-challenger): Output Bisection Game Genesis Output Root Fetching #8394 👈
    • PR fix(op-challenger): Absolute Prestate Provider Refactor #8453

This stack of pull requests is managed by Graphite.

[codecov]

Codecov Report

Merging #8394 (2ac6817) into develop (db04c8b) will increase coverage by 28.84%.
The diff coverage is n/a.

❗ Current head 2ac6817 differs from pull request most recent head 74a4849. Consider uploading reports for the commit 74a4849 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #8394       +/-   ##
============================================
+ Coverage    34.64%   63.48%   +28.84%     
============================================
  Files          167       16      -151     
  Lines         7146     1427     -5719     
  Branches      1207        0     -1207     
============================================
- Hits          2476      906     -1570     
+ Misses        4521      475     -4046     
+ Partials       149       46      -103     

Flag	Coverage Δ
cannon-go-tests	63.48% <ø> (ø)
chain-mon-tests	?
common-ts-tests	?
contracts-bedrock-tests	?
contracts-ts-tests	?
core-utils-tests	?
sdk-next-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 151 files with indirect coverage changes

[clabby]

Logic lgtm; Will defer to a go reviewer to give approval.

[ajsutton]

LGTM.