feat(ctb): OutputBisectionGame

[clabby]

Overview

Implements the first iteration of the OutputBisectionGame, specified in Notion.

Notes

• Couple of follow-up nits from @tynes addressed.
• Change local key context value.
• Refactor unit tests that were disabled / add unit tests for changed functionality.
  • Adding local inputs has changed a decent bit; Need new coverage for this.
  • Claim verification on the split level - verification of the VM status byte has moved from when the contract is created to each time an exec trace subgame begins.
• Handle attack on genesis in the output root bisection phase.
• Protect against misconfigured depths (odd/even - who makes the step? who makes the exec trace root claims?).

Metadata
closes https://github.com/ethereum-optimism/client-pod/issues/94
closes https://github.com/ethereum-optimism/client-pod/issues/256

[coderabbitai]

Walkthrough

Walkthrough

The changes across the codebase involve updates to contract deployment configurations, error handling enhancements, and test modifications. A new field related to output bisection game genesis output root has been added to several contracts, and hard-coded values have replaced configurable ones in some instances. Error handling has been improved in various functions, and new test scenarios have been added to ensure robustness. Additionally, there are updates to logging, signal handling, and temporary directory creation for end-to-end testing.

Changes

File Path	Summary
op-chain-ops/genesis/config.go	Added OutputBisectionGameGenesisOutputRoot field to DeployConfig struct.
packages/contracts-bedrock/scripts/Deploy.s.sol	Added _genesisOutputRoot parameter and changed _maxGameDepth to a hard-coded value.
packages/contracts-bedrock/scripts/DeployConfig.s.sol	Added outputBisectionGameGenesisOutputRoot variable and updated constructor.
packages/contracts-bedrock/src/dispute/OutputBisectionGame.sol	Added GENESIS_OUTPUT_ROOT variable, updated constructor, and modified functions.
packages/contracts-bedrock/src/dispute/interfaces/IOutputBisectionGame.sol	Updated resolveClaim function comment.
packages/contracts-bedrock/test/dispute/OutputBisectionGame.t.sol	Changed constants, modified game instantiation, and added new test functions.
op-challenger/game/fault/...	Modified registerOutputCannon and NewOutputCannonTraceAccessor functions to use splitDepth.
op-e2e/...	Added cleanup functions, timeout contexts, and updated signal handling and logging.
op-node/rollup/derive/...	Improved error handling, added new functions, and updated test functions.
op-node/cmd/batch_decoder/...	Updated batch_decoder logic and added new flags and configuration loading.

Note: The table groups files with similar changes together to save space and omits parts of the file paths that are not essential for identifying the file.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[clabby]

Current dependencies on/for this PR:

• develop
  • PR feat(ctb): OutputBisectionGame #8351 👈
    • PR feat(ctb): OutputBisectionGame test refactor + fixes #8346

This stack of pull requests is managed by Graphite.

[codecov]

Codecov Report

Merging #8351 (833e355) into develop (179aea6) will increase coverage by 0.38%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8351      +/-   ##
===========================================
+ Coverage    40.01%   40.40%   +0.38%     
===========================================
  Files          164      132      -32     
  Lines         6180     5336     -844     
  Branches      1004      855     -149     
===========================================
- Hits          2473     2156     -317     
+ Misses        3633     3106     -527     
  Partials        74       74              

Flag	Coverage Δ
cannon-go-tests	63.48% <ø> (ø)
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-bedrock-tests	20.28% <0.00%> (-0.11%)	⬇️
contracts-ts-tests	100.00% <ø> (ø)
core-utils-tests	?
sdk-next-tests	42.18% <ø> (ø)
sdk-tests	42.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...tracts-bedrock/src/dispute/OutputBisectionGame.sol	0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

[ajsutton]

Logic looks good to me. I'm guessing not all the bindings changes will be required when updated to the latest develop. I haven't tried to review the solidity tests carefully but all the solidity code should be reviewed by someone who knows what they're doing there anyway. :)

The local context calculation and finding the starting and disputed claims matches what the challenger does.

[tynes]

I wouldn't say that I have the context to thoroughly review the implementation details but the code looks sane to me. Going to need to rely on testing for correctness

[refcell]

dogfood, otherwise lgtm

[refcell]

Need this in to fix tests in #8394 since it relies on having the GENESIS_OUTPUT_ROOT exposed to validate the output bisection game top split

[refcell]

[ajsutton]

The test failing in the merge queue is for the output bisection game - exactly what this PR is changing. I'd say it's legit broken when this PR combines with the latest changes on develop, but either way it definitely is getting flakier so we shouldn't just keep retrying the merge an need to work out how to fix it.

[refcell]

The test failing in the merge queue is for the output bisection game - exactly what this PR is changing. I'd say it's legit broken when this PR combines with the latest changes on develop, but either way it definitely is getting flakier so we shouldn't just keep retrying the merge an need to work out how to fix it.

The test failing is the codecov test which is saying 0% of the output bisection game is covered with tests (incorrect). This is why i was attempting to add to the merge queue a few times...

[ajsutton]

The test failing is the codecov test which is saying 0% of the output bisection game is covered with tests (incorrect). This is why i was attempting to add to the merge queue a few times...

TestOutputCannonGame e2e test was failing and preventing the merge. The code coverage isn't actually a merge blocker. 😀