feat[contracts]: Add storage slot parsing functions for chugsplash#716
Merged
smartcontracts merged 9 commits intov0.4.0-rcfrom May 4, 2021
Merged
feat[contracts]: Add storage slot parsing functions for chugsplash#716smartcontracts merged 9 commits intov0.4.0-rcfrom
smartcontracts merged 9 commits intov0.4.0-rcfrom
Conversation
|
karlfloersch
reviewed
May 3, 2021
Contributor
|
Oh also probably good to change this PR to be against |
smartcontracts
force-pushed
the
feat/chugsplash-slot-parser
branch
from
b7691d1 to
98f83f9
Compare
karlfloersch
reviewed
May 3, 2021
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
This is great! The two things that I'd suggest doing before a merge:
- Consider adding a version check to the storage slot parser (if possible)
- Add an issue to perform additional smoddit tests with whatever testing you think would be valuable to add in the future.
ben-chain
pushed a commit
to ben-chain/optimism
that referenced
this pull request
May 6, 2021
…thereum-optimism#716) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
smartcontracts
added a commit
that referenced
this pull request
May 17, 2021
) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
ben-chain
pushed a commit
to ben-chain/optimism
that referenced
this pull request
May 18, 2021
…thereum-optimism#716) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
gakonst
pushed a commit
that referenced
this pull request
May 20, 2021
) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
gakonst
pushed a commit
that referenced
this pull request
May 21, 2021
) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
smartcontracts
added a commit
that referenced
this pull request
May 30, 2021
) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
ben-chain
pushed a commit
to ben-chain/optimism
that referenced
this pull request
Jun 23, 2021
…thereum-optimism#716) * wip: start storage slot parsing lib for chugsplash * add support for packed storage slots and do bytesN correctly * fix lint errors * Simplify some repeated logic * style: small improvements and comments * Update testing for storage library * test: Add some tests for unsupported types * fix: use semver to block unsupported solidity versions
OptimismBot
pushed a commit
that referenced
this pull request
Dec 2, 2025
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat(executor): EIP-1559 configurability spec updates * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the storage slot parsing function that we'll need for chugsplash + tests. We mainly want to make sure that we have adequate test coverage + that we're able to encode all the various types that we want to encode.
Metadata