feat[contracts]: Chugsplash integration#653
Conversation
|
| * @param addresses Contract addresses to inject into {{ contract.X }} template strings. | ||
| * @returns Modified variable with template strings replaced. | ||
| */ | ||
| const parseVariable = ( |
There was a problem hiding this comment.
This needs unit tests. It is also possible to use templating libraries that have unit tests
| [name: string]: string | ||
| } = {} | ||
| ): SolidityVariable => { | ||
| if (typeof variable === 'string') { |
| /** | ||
| * @title ChugSplashDeployer | ||
| */ | ||
| contract ChugSplashDeployer { |
There was a problem hiding this comment.
Btw one high level bit of feedback here is I think that more 'deployment'-esque words could make the operation of this contract clearer. For instance hasActiveBundle seems more implicit than hasActiveDeployment.
I feel like it's OK to have deploy-specific terminology here because the ChugSplashDeployer is going to have to handle logic for things like shutting down the contracts to begin a deploy, and restarting them to end the deploy. So idk it seems like it's low value to make things more abstract than they need to be at least at first. Eventually we can break it out into a BundleExecutor or something like that, but in the meantime I just like reminding folks what they are reading
|
|
||
| function approveTransactionBundle( | ||
| bytes32 _bundleHash, | ||
| uint256 _bundleSize |
There was a problem hiding this comment.
This should also take in a version string I think which we can emit and thereby track the versions of each deployment. Or alternatively there is a version in the bundle
Closes #528 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closes #528 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closes #528 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closes #528 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 participants
Description
Working on chugsplash integration. Waiting for
ovmSETCODEandovmSETSTORAGEsupport before continuing.