Skip to content

Comments

Renames prettier config files#649

Merged
gakonst merged 2 commits intomasterfrom
fix/rename-prettier-config
Apr 28, 2021
Merged

Renames prettier config files#649
gakonst merged 2 commits intomasterfrom
fix/rename-prettier-config

Conversation

@gigamesh
Copy link
Contributor

@gigamesh gigamesh commented Apr 27, 2021

VSCode's prettier plugin ignores prettier-config.json files (the file name is non-standard). Renaming to .prettierrc.json makes it work.

https://prettier.io/docs/en/configuration.html

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2021

⚠️ No Changeset found

Latest commit: 6a87065

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gakonst gakonst force-pushed the fix/rename-prettier-config branch from 0021d38 to e62854b Compare April 27, 2021 19:31
@snario
Copy link
Contributor

snario commented Apr 27, 2021

I think this is failing due to cached files in the builder image? @gakonst we may need a way to bump the builder.

@gakonst gakonst force-pushed the fix/rename-prettier-config branch from e62854b to e6e3a68 Compare April 28, 2021 13:52
@gakonst gakonst merged commit 4c2fbde into master Apr 28, 2021
@gakonst gakonst deleted the fix/rename-prettier-config branch April 28, 2021 15:15
@snario
Copy link
Contributor

snario commented Apr 28, 2021

Ah, it was a symlinking issue

InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* Renames prettier config files

* chore: rename the remaining prettierrc files

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
* chore(mpt): mpt noop trait impls

* chore(mpt): mpt noop trait impls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants