Skip to content

Add eth_getBlockByHash endpoint #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karlfloersch merged 5 commits into from
Apr 10, 2020
Merged

Add eth_getBlockByHash endpoint #64

karlfloersch merged 5 commits into from
Apr 10, 2020

Conversation

@karlfloersch
Copy link
Contributor

@karlfloersch karlfloersch commented Apr 1, 2020

Description

This ticket adds support for eth_getBlockByHash endpoint which is used in projects like The Graph.

Metadata

Fixes

Contributing Agreement

K-Ho
K-Ho suggested changes Apr 2, 2020
View reviewed changes
packages/rollup-full-node/src/app/web3-rpc-handler.ts
[blockHash, fullObjects]
)
const block = this.parseInternalBlock(res, fullObjects)

Copy link
Contributor

@K-Ho K-Ho Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to set timestamp as well

Copy link
Contributor Author

@karlfloersch karlfloersch Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think that you shouldn't need to explicitly set the timestamp because I use this.parseInternalBlock(...) which should do this for us.

packages/rollup-full-node/test/app/web-rpc-handler.spec.ts Outdated
blockRetrievedByHash.should.deep.equal(blockRetrievedByNumber)
})

it('should return the same black as eth_getBlockByNumber even after another block is created', async () => {
Copy link
Contributor

@K-Ho K-Ho Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black -> block 😆

Copy link
Contributor Author

@karlfloersch karlfloersch Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Fixing!

packages/rollup-full-node/test/app/web-rpc-handler.spec.ts Outdated
'ovm_getExecutionManagerAddress',
[]
)
const { timestamp } = await httpProvider.getBlock('latest')
Copy link
Contributor

@K-Ho K-Ho Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check that this timestamp is the same as the timestamp from getBlockByNumber is the same as that of getBlockByHash

Copy link
Contributor Author

@karlfloersch karlfloersch Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I just removed that call to get the timestamp because the timestamp is mostly being checked in the following deep.equal call. However, one thing to note is these tests aren't great as they do rely on the previous few tests working (as basically it's just checking that the two endpoints equal each other). However, tbh I don't know a great way to fix this as any test that I do will probably rely on getBlock('latest') because otherwise I wouldn't know the block hash of the block without inspecting some low level Ganache stuff.

All this to say I made a minor change & explained my reasoning for doing it this way so... do you accept it? lool

K-Ho
K-Ho approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@K-Ho K-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@karlfloersch karlfloersch merged commit a6124ae into ethereum-optimism:master Apr 10, 2020
snario pushed a commit that referenced this pull request Apr 14, 2021
@gakonst
Bond Manager Deposit bugfix (#64)
f24339f 
* fix(bond): always deposit requiredCollateral

This means that we have to remove the setRequiredCollateral function to avoid:
1. Publisher deposits, requiredCollateral goes up, publisher withdraws more than they deposited
2. Publisher deposits, fraud happens, requiredCollateral goes up, more than the user's deposit gets
distributed in fraud claims

* fix(bond): remove redundant batchIndex parameter
max-sanchez added a commit to hemilabs/optimism that referenced this pull request Apr 16, 2024
@max-sanchez
Squashed 'heminetwork/' changes from b3993a073..88047e707
690ee85 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 17, 2024
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
b6b1308 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 4, 2025
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
f317a9a 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 7, 2025
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
65c9bb8 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
gd-0 pushed a commit to gattaca-com/based-optimism that referenced this pull request May 19, 2025
@Arkenan @ManuelBilbao @gd-0
SSZ Marshalling and unmarshalling for signed types (ethereum-optimism#64
1038fb4 
)

Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
gd-0 pushed a commit to gattaca-com/based-optimism that referenced this pull request May 19, 2025
@Arkenan @ManuelBilbao @gd-0
SSZ Marshalling and unmarshalling for signed types (ethereum-optimism#64
a9b6ae3 
)

Co-authored-by: Manuel Iñaki Bilbao <[email protected]>
blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Aug 11, 2025
@blockchaindevsh
always estimate gas if inbox contract is enabled (ethereum-optimism#64)
6edd35b
theochap pushed a commit that referenced this pull request Dec 10, 2025
@refcell
Merge pull request #64 from ethereum-optimism/dependabot/go_modules/f…
7348b2e 
…pvm-tests/cannon-go-tests/google.golang.org/protobuf-1.33.0

Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /fpvm-tests/cannon-go-tests
theochap pushed a commit that referenced this pull request Jan 14, 2026
@refcell
Merge pull request #64 from ethereum-optimism/dependabot/go_modules/f…
05d985a 
…pvm-tests/cannon-go-tests/google.golang.org/protobuf-1.33.0

Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /fpvm-tests/cannon-go-tests
theochap pushed a commit that referenced this pull request Jan 15, 2026
@refcell
feat: Workflow to validate no_std Compatibility (#64)
a1007d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@K-Ho K-Ho K-Ho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karlfloersch @K-Ho