Skip to content

Fix evm_increaseTime bugs #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masonforest merged 9 commits into from
Mar 16, 2020
Merged

Fix evm_increaseTime bugs #36

masonforest merged 9 commits into from
Mar 16, 2020

Conversation

@masonforest
Copy link

@masonforest masonforest commented Mar 11, 2020

Description

Fix evm_increaseTime bugs:

  • evm_increaseTime should accepts numbers as well as hex strings
  • evm_revert should revert changes made by evm_increaseTime

Fixes

Contributing Agreement

willmeister
willmeister approved these changes Mar 11, 2020
View reviewed changes
Copy link

@willmeister willmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/core-utils/src/app/misc.ts Outdated
* @param str the String to parse
* @returns the parsed number.
*/
export const maybeParseHexString = (
Copy link

@willmeister willmeister Mar 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I like the maybe, returnInputAsNumber or castToNumber might be a better name 😄

Copy link
Author

@masonforest masonforest Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh haha I was going with maybe as in the maybe type although there maybe refers to a noun not a verb. In any case castToNumber is more clear: Fixed! -> Rename maybeParseHexString to castToNumber

@masonforest
Copy link
Author

masonforest commented Mar 11, 2020

Closing this in favor of YAS-245.

@masonforest masonforest reopened this Mar 12, 2020
@masonforest masonforest merged commit 6362be2 into master Mar 16, 2020
@masonforest masonforest deleted the YAS-243/Synthetix/FixIncreaseTimeBugs branch March 23, 2020 13:21
gakonst added a commit that referenced this pull request Apr 12, 2021
@gakonst
feat: import the message relayer service (#36)
757ccee 
* feat: import the message relayer service

https://github.com/ethereum-optimism/optimism-ts-services/blob/1c6f8ad07afadc37ace76c9c63635d9b5132f6bd/src/services/message-relayer.service.ts

* chore: clean up unused types

* fix: do not try to run relayer unit tests

* ops(message-relayer): add docker image and compose settings

* test: add L1 <> L2 communication

* ci: parallelize building steps

* ci: try to resolve hardhat race condition
snario pushed a commit that referenced this pull request Apr 14, 2021
@tynes
deploy portability (#36)
3c3aa6b 
* deploy: remove dependency on tsc

* deploy: fix typo

* deployer: fix typo
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
@gakonst
feat: import the message relayer service (#36)
352ce2d 
* feat: import the message relayer service

https://github.com/ethereum-optimism/optimism-ts-services/blob/1c6f8ad07afadc37ace76c9c63635d9b5132f6bd/src/services/message-relayer.service.ts

* chore: clean up unused types

* fix: do not try to run relayer unit tests

* ops(message-relayer): add docker image and compose settings

* test: add L1 <> L2 communication

* ci: parallelize building steps

* ci: try to resolve hardhat race condition
protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022
@karlfloersch
Update roadmap progress bars (ethereum-optimism#36)
a205b36
@mslipper mslipper mentioned this pull request May 16, 2022
Merged
protolambda pushed a commit that referenced this pull request Jun 16, 2023
@geohot
Merge pull request #36 from geohot/oracletest
635af73 
oracle test
max-sanchez added a commit to hemilabs/optimism that referenced this pull request Apr 16, 2024
@max-sanchez
Squashed 'heminetwork/' changes from b3993a073..88047e707
690ee85 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 17, 2024
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
b6b1308 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 4, 2025
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
f317a9a 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 pushed a commit to hemilabs/optimism that referenced this pull request Apr 7, 2025
@max-sanchez @ClaytonNorthey92
Squashed 'heminetwork/' changes from b3993a073..88047e707
65c9bb8 
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (ethereum-optimism#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (ethereum-optimism#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (ethereum-optimism#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025
@blockchaindevsh
fix ISoulGasToken.__constructor__ (ethereum-optimism#36)
945d0f2
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
@sieniven
Fix: Fix local devnet config file (ethereum-optimism#36)
918e115 
* Update config files

* Fix
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
Make versions of packages independent (#36)
6286b2a
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
@Zena-park
fix: stakeOfAllLayers, stakeOfAllLayersAt(uint256 snapshotId) ethereu…
c73d0f2 
…m-optimism#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@willmeister willmeister willmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masonforest @willmeister