fix: Fix various minor linting errors not caught by CI#635
Merged
smartcontracts merged 2 commits intomasterfrom Apr 26, 2021
Merged
fix: Fix various minor linting errors not caught by CI#635smartcontracts merged 2 commits intomasterfrom
smartcontracts merged 2 commits intomasterfrom
Conversation
|
annieke
approved these changes
Apr 26, 2021
Contributor
annieke
left a comment
annieke
left a comment
There was a problem hiding this comment.
also should look into making ci catch these!
snario
suggested changes
Apr 26, 2021
snario
approved these changes
Apr 26, 2021
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
…mism#635) * fix: Fix various minor linting errors not caught by CI * Delete bright-rice-pump.md
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
emhane
added a commit
that referenced
this pull request
Feb 4, 2026
Ref op-rs/op-reth#631 - Removes `safe_fn` closure as arg from `initialize` by making `initialize` a method of `InitializationJob` - Moves save functions out of `InitializationJob` into impls of trait method of new trait `InitTable::save_entries` - Uses `size_hint` to avoid cost of heap re-allocations - Removes redundant clone
emhane
added a commit
that referenced
this pull request
Feb 4, 2026
Ref op-rs/op-reth#631 - Removes `safe_fn` closure as arg from `initialize` by making `initialize` a method of `InitializationJob` - Moves save functions out of `InitializationJob` into impls of trait method of new trait `InitTable::save_entries` - Uses `size_hint` to avoid cost of heap re-allocations - Removes redundant clone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not sure what happened here. Seems a linting error snuck by CI.