Conversation
🦋 Changeset detectedLatest commit: 8497e65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
force-pushed
the
fix/eth-call-blocknumber
branch
from
c747b02 to
6cb103d
Compare
| @@ -968,6 +981,8 @@ func DoCall(ctx context.Context, b Backend, args CallArgs, blockNrOrHash rpc.Blo | |||
| gp := new(core.GasPool).AddGas(math.MaxUint64) | |||
| if vm.UsingOVM { | |||
There was a problem hiding this comment.
We need a less error prone way of getting an EVM with the correct context set, otherwise we need to make sure to mutate the evm context externally in each codepath that it is used. Thinking about the correct place to slot in will be left to the berlin geth migration
There was a problem hiding this comment.
Can you open an issue describing the desired solution you have in mind?
| @@ -968,6 +981,8 @@ func DoCall(ctx context.Context, b Backend, args CallArgs, blockNrOrHash rpc.Blo | |||
| gp := new(core.GasPool).AddGas(math.MaxUint64) | |||
| if vm.UsingOVM { | |||
There was a problem hiding this comment.
Can you open an issue describing the desired solution you have in mind?
* l2geth: correct timestamp + blocknumber in eth_call * test: correct eth_call blocknumber + timestamp * chore: add changeset
#632) Ref op-rs/op-reth#631 - Changes nested database tx type to owned type as has no need to be ref - Uses `AsyncFnOnce`(new in Rust 1.85) instead of generic future return type
#632) Ref op-rs/op-reth#631 - Changes nested database tx type to owned type as has no need to be ref - Uses `AsyncFnOnce`(new in Rust 1.85) instead of generic future return type
2 participants
Description
Uses the correct
block.numberandblock.timestampforeth_call. It was previously using the block number and timestamp of the L2 block instead of the L1 based context.Metadata
Fixes #530