fix[contracts]: Separately generate OVM typechain artifacts#597
fix[contracts]: Separately generate OVM typechain artifacts#597smartcontracts merged 5 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: e051c8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ben-chain
left a comment
ben-chain
left a comment
There was a problem hiding this comment.
Nice! I just have one question about CI here.
packages/contracts/package.json
Outdated
| "lint:fix:typescript": "prettier --config prettier-config.json --write \"hardhat.config.ts\" \"{src,test}/**/*.ts\"", | ||
| "lint": "yarn lint:fix && yarn lint:check", | ||
| "lint:check": "tslint --format stylish --project .", | ||
| "lint:fix": "prettier --config prettier-config.json --write \"hardhat.config.ts\" \"{src,test,tasks}/**/*.ts\"", |
There was a problem hiding this comment.
Noting this changes the behavior of yarn lint to be fixing instead of checking. Do we need to update the CI to make sure it doesn't let some auto-fixable things through the cracks?
There was a problem hiding this comment.
This is a good point, going to revert this change.
|
oh woah nice did not know this could be solved at the optimism tooling level! |
|
ah okay this issue just fixes this issue for |
Adding an issue for community-hub so that the we can add this note in the docs |
gakonst
force-pushed
the
fix/typechain-ovm-artifacts
branch
from
f552a14 to
e051c8b
Compare
|
It seems to me the "proper" way to fix this would be to do this at hardhat-ovm? I've pushed this in e051c8b. @smartcontracts please confirm/review and merge if you agree with this change. |
* fix[contracts]: Generate typechain artifacts for ovm separately * fix[contracts]: Add ovm typechain artifacts to package json * chore[contracts]: Add changeset * fix[contracts]: Revert change to package.json * feat(hh-ovm): generate typechain bindings in specific directory Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
Adds generic helper methods for decoding and recovering transactions on `OpExecutionPayload`, mirroring the functionality available in `OpPayloadAttributes` ## Changes Added four new methods to `impl OpExecutionPayload`: - `decoded_transactions<T: Decodable2718>()` - Decode transactions to any type implementing `Decodable2718` - `decoded_transactions_with_encoded<T>()` - Same as above but includes original encoded bytes - `recovered_transactions<T>()` - Recover signer addresses for types implementing both `Decodable2718` and `SignerRecoverable` - `recovered_transactions_with_encoded<T>()` - Same as above but includes original encoded bytes These methods provide the same functionality as the existing helpers in `OpPayloadAttributes`
This PR improves the robustness of the OP-Reth Proofs ExEx by process notifications asynchronously(to avoid WAL backpressure) when the gap between proof storage and the tip is big. This change ensures that notification pipeline is able to keep up and gracefully handle the gap. Closes #597 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
This PR improves the robustness of the OP-Reth Proofs ExEx by process notifications asynchronously(to avoid WAL backpressure) when the gap between proof storage and the tip is big. This change ensures that notification pipeline is able to keep up and gracefully handle the gap. Closes #597 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
5 participants
Description
Fixes an issue where only EVM or OVM artifacts would be included in typechain, depending on whichever was compiled last. Now will put OVM-compiled typechain artifacts into
types-ovm.Metadata