Skip to content

feat(op-challenger): DisputeGameFactory Watcher#5842

Merged
OptimismBot merged 4 commits intodevelopfrom
refcell/challenger/dgfwatcher
Jun 5, 2023
Merged

feat(op-challenger): DisputeGameFactory Watcher#5842
OptimismBot merged 4 commits intodevelopfrom
refcell/challenger/dgfwatcher

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented May 31, 2023

Description

Stacked ontop of #5831, this pr contains the logic for the watch factory
subcommand to listen for newly created dispute games from the dispute
game factory.

Metadata

Fixes CLI-4063

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

⚠️ No Changeset found

Latest commit: c8a82e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refcell
Copy link
Contributor Author

refcell commented May 31, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@refcell refcell self-assigned this Jun 1, 2023
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks ok, but I'm struggling to understand what the actual requirements are here. That's probably just me lacking context, but it would certainly help me if there were a better description of what this does and what it's building towards in the PR description. Future coders wondering why this code is the way it is may also appreciate that. :)

@refcell refcell force-pushed the refcell/challenger/subcommands branch from a86638d to 7fc09b6 Compare June 2, 2023 11:30
@refcell refcell force-pushed the refcell/challenger/dgfwatcher branch 2 times, most recently from a46636f to 169dd3e Compare June 2, 2023 12:24
@refcell refcell requested a review from ajsutton June 2, 2023 12:26
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the couple of questions about whether we can narrow the interface and if we need to close resources. Neither are a big deal though.

@refcell refcell force-pushed the refcell/challenger/subcommands branch from d1bcf2b to 5e43d79 Compare June 5, 2023 14:08
@refcell refcell force-pushed the refcell/challenger/dgfwatcher branch 2 times, most recently from 26abcde to 176c4bb Compare June 5, 2023 14:11
Base automatically changed from refcell/challenger/subcommands to develop June 5, 2023 14:26
@refcell refcell force-pushed the refcell/challenger/dgfwatcher branch from 176c4bb to c8a82e8 Compare June 5, 2023 14:30
@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit c8a82e8
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/647df18e513f8f00085322e9

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #5842 (23eaebf) into develop (e635fdd) will increase coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 23eaebf differs from pull request most recent head c8a82e8. Consider uploading reports for the commit c8a82e8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5842      +/-   ##
===========================================
+ Coverage    40.49%   40.76%   +0.27%     
===========================================
  Files          365      317      -48     
  Lines        28294    26125    -2169     
  Branches       438        0     -438     
===========================================
- Hits         11457    10650     -807     
+ Misses       15858    14497    -1361     
+ Partials       979      978       -1     
Flag Coverage Δ
bedrock-go-tests 40.76% <0.00%> (+0.01%) ⬆️
common-ts-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

@OptimismBot OptimismBot merged commit 4cc747b into develop Jun 5, 2023
@OptimismBot OptimismBot deleted the refcell/challenger/dgfwatcher branch June 5, 2023 14:45
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants