feat(op-challenger): DisputeGameFactory Watcher#5842
Conversation
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
ajsutton
left a comment
There was a problem hiding this comment.
This code looks ok, but I'm struggling to understand what the actual requirements are here. That's probably just me lacking context, but it would certainly help me if there were a better description of what this does and what it's building towards in the PR description. Future coders wondering why this code is the way it is may also appreciate that. :)
a86638d to
7fc09b6
Compare
a46636f to
169dd3e
Compare
ajsutton
left a comment
There was a problem hiding this comment.
LGTM. Just the couple of questions about whether we can narrow the interface and if we need to close resources. Neither are a big deal though.
d1bcf2b to
5e43d79
Compare
26abcde to
176c4bb
Compare
176c4bb to
c8a82e8
Compare
✅ Deploy Preview for opstack-docs canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5842 +/- ##
===========================================
+ Coverage 40.49% 40.76% +0.27%
===========================================
Files 365 317 -48
Lines 28294 26125 -2169
Branches 438 0 -438
===========================================
- Hits 11457 10650 -807
+ Misses 15858 14497 -1361
+ Partials 979 978 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |

Description
Stacked ontop of #5831, this pr contains the logic for the
watch factorysubcommand to listen for newly created dispute games from the dispute
game factory.
Metadata
Fixes CLI-4063