Skip to content

Add multisig transactions and verification script for bedrock migration#5824

Merged
zchn merged 4 commits intodevelopfrom
k0530/cli-4032-multisig
Jun 5, 2023
Merged

Add multisig transactions and verification script for bedrock migration#5824
zchn merged 4 commits intodevelopfrom
k0530/cli-4032-multisig

Conversation

@zchn
Copy link
Contributor

@zchn zchn commented May 30, 2023

Description

Add multisig transactions and verification script for bedrock migration.

Tests

For CheckForBedrockMigration.s.sol: Manually executed the script based on the instructions in README.md.
For json files: Manually loaded them into Safe and generated tenderly simulations:

  1. b1.json: Tenderly
  2. b1.json+b2.json: Tenderly
  3. b1.json+b2.json+b3.json: Tenderly
  4. b1.json+escapeHatch.json: Tenderly
  5. b1.json+b2.json+escapeHatch.json: Tenderly

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023

⚠️ No Changeset found

Latest commit: fc68616

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit fc68616
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/647a2cf7f365610008a9b5f1
😎 Deploy Preview https://deploy-preview-5824--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zchn zchn marked this pull request as ready for review May 30, 2023 16:42
@zchn zchn requested a review from a team as a code owner May 30, 2023 16:42
@zchn zchn requested review from clabby, mslipper and tynes May 30, 2023 16:42
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 1, 2023

Semgrep found 1 todos_require_linear finding:

  • op-wheel/engine/engine.go: L124

Please create a Linear ticket for this TODO.

Ignore this finding from todos_require_linear.

Semgrep found 1 err-todo finding:

  • op-wheel/engine/engine.go: L124

TODO in error handling code

Ignore this finding from err-todo.

@zchn zchn requested review from smartcontracts and removed request for clabby June 5, 2023 14:14
@zchn zchn merged commit 921fc82 into develop Jun 5, 2023
@zchn zchn deleted the k0530/cli-4032-multisig branch June 5, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants