refactor[contracts]: Remove OVM_L1MessageSender#562
Closed
smartcontracts wants to merge 3 commits intomasterfrom
Closed
refactor[contracts]: Remove OVM_L1MessageSender#562smartcontracts wants to merge 3 commits intomasterfrom
smartcontracts wants to merge 3 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: 6847015 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Closing this after conversation with Karl. |
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
emhane
pushed a commit
that referenced
this pull request
Feb 4, 2026
Closes #562 Validated the optimization by rewriting an initial state with N=50,000 updated entries. - Throughput: Increased by ~20.9% (326k → 394k entries/sec). - Latency: Reduced by ~17.2% (153ms → 126ms). ``` Old approach: Rewrite Duration: 153.26ms Throughput: 326,248 entries/sec New approach: Rewrite Duration: 126.77ms Throughput: 394,410 entries/sec ``` bench: op-rs/op-reth@180e132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
OVM_L1MessageSenderpredeploy in favor of using theLib_ExecutionManagerWrapper.Discussion
L2CrossDomainMessenger.spec.tswas using an EVM-compiled version of the contract during testing. Removal ofOVM_L1MessageSendermeans that we're relying on the customkallbuiltin which only exists inoptimistic-solc. As a result, that test file doesn't make sense anymore. Although it really didn't make much sense to be testing the EVM-compiled contract in the first place. Those tests will not work without a complete rewrite of the test file to use the same pattern that our other L2-compiled contracts are using. However, the current pattern is extremely ugly and requires a lot of unnecessary effort. It would be ideal if we added a ticket to develop a better testing pattern for these L2 contracts and simply rewrote this test file with the new pattern. For now I've just deleted the old file. Thoughts?