feat(ctb): Remove division from hasMinGas for precision#5540
Merged
OptimismBot merged 1 commit intodevelopfrom Apr 26, 2023
Merged
feat(ctb): Remove division from hasMinGas for precision#5540OptimismBot merged 1 commit intodevelopfrom
hasMinGas for precision#5540OptimismBot merged 1 commit intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 6eb0543 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Contributor
|
Hey @clabby! This PR has merge conflicts. Please fix them before continuing review. |
Contributor
|
How do you feel about putting the formula into the contract? Would help future reviewers understand. |
Contributor
|
Going to need to rebase + update semver for portal + both messengers |
Add changeset Semver bump Resolve conflicts
clabby
force-pushed
the
clabby/ctb/safe-call-rounding
branch
from
9808498 to
6eb0543
Compare
maurelian
approved these changes
Apr 26, 2023
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
seolaoh
added a commit
to kroma-network/kroma
that referenced
this pull request
Aug 9, 2023
…Gas` Adjusts `SafeCall.callWithMinGas` to account for the worst-case cost of 3/5 of the `CALL` opcode's dynamic gas factors: - `address_access_cost` - `positive_value_cost` - `value_to_empty_account_cost` As for `memory_expansion_cost` & `code_execution_cost`, these are expected to be covered by the `minGasLimit` itself. Also removes the division from `hasMinGas` for extra precision. See: - ethereum-optimism/optimism#5470 - ethereum-optimism/optimism#5540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes the division from
hasMinGasfor extra precision.Old
New
Metadata
Fixes CLI-3892