Skip to content

chore: log errors on monotonicity fixes #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annieke merged 2 commits into from
Apr 22, 2021
Merged

chore: log errors on monotonicity fixes #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e3f9e
chore: log errors on monotonicity fixes
annieke Apr 22, 2021
c8d7d85
add changeset
annieke Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-ladybugs-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eth-optimism/batch-submitter": patch
---

log errors for monotonicity violations
4 changes: 2 additions & 2 deletions packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ export class TransactionBatchSubmitter extends BatchSubmitter {
ele.timestamp < earliestTimestamp ||
ele.blockNumber < earliestBlockNumber
) {
this.log.warn('Fixing timestamp/blockNumber too small', {
this.log.error('Fixing timestamp/blockNumber too small', {
oldTimestamp: ele.timestamp,
newTimestamp: earliestTimestamp,
oldBlockNumber: ele.blockNumber,
Expand All @@ -514,7 +514,7 @@ export class TransactionBatchSubmitter extends BatchSubmitter {
ele.timestamp > latestTimestamp ||
ele.blockNumber > latestBlockNumber
) {
this.log.warn('Fixing timestamp/blockNumber too large.', {
this.log.error('Fixing timestamp/blockNumber too large.', {
oldTimestamp: ele.timestamp,
newTimestamp: latestTimestamp,
oldBlockNumber: ele.blockNumber,
Expand Down