chore: log errors on monotonicity fixes#553
Merged
Conversation
🦋 Changeset detectedLatest commit: c8d7d85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
approved these changes
Apr 22, 2021
Contributor
|
We haven't had a montonicity error in quite some time which is good |
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* chore: log errors on monotonicity fixes * add changeset
agusduha
pushed a commit
that referenced
this pull request
Sep 25, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
* feat: fee splitter system (#469) ---- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: failing tests (#553) * refactor: revenue sharing config (#538) * fix: pre pr and semgrep (#565) * fix: warnings (#571) * fix: tests failing on fork environment (#575) * fix: use encode call on constructors (#578) * feat: add integration splitter test (#581) * fix: integration test nits (#583) * test: more coverage on splitter tests (#594) --------- Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: add missing operator fee vault field (#616) * feat: invariants and tests (#595) * fix: ir informationals (#609) * fix: pre pr (#622) * refactor: use cdm (#624) * fix: update withdrawal gas limit value on check (#627) * fix: remove rev share field from deploy op chain input struct (#628) * refactor: remove initializer and vaults getter changes (#631) * fix: remove immutable check over vaults (#634) Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com> * fix: audit findings (#658) * fix: pre pr * feat: add user guide docs for rev sharing on op deployer (#666) * docs: add create2 comment (#667) --------- Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
OptimismBot
pushed a commit
that referenced
this pull request
Dec 5, 2025
* feat: fee splitter system (#469) ---- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: failing tests (#553) * refactor: revenue sharing config (#538) * fix: pre pr and semgrep (#565) * fix: warnings (#571) * fix: tests failing on fork environment (#575) * fix: use encode call on constructors (#578) * feat: add integration splitter test (#581) * fix: integration test nits (#583) * test: more coverage on splitter tests (#594) --------- Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: add missing operator fee vault field (#616) * feat: invariants and tests (#595) * fix: ir informationals (#609) * fix: pre pr (#622) * refactor: use cdm (#624) * fix: update withdrawal gas limit value on check (#627) * fix: remove rev share field from deploy op chain input struct (#628) * refactor: remove initializer and vaults getter changes (#631) * fix: remove immutable check over vaults (#634) Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com> * fix: audit findings (#658) * fix: pre pr * feat: add user guide docs for rev sharing on op deployer (#666) * docs: add create2 comment (#667) --------- Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
maurelian
added a commit
that referenced
this pull request
Dec 9, 2025
* feat: introduce fee splitter for revenue share (#17536) * feat: fee splitter system (#469) ---- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: failing tests (#553) * refactor: revenue sharing config (#538) * fix: pre pr and semgrep (#565) * fix: warnings (#571) * fix: tests failing on fork environment (#575) * fix: use encode call on constructors (#578) * feat: add integration splitter test (#581) * fix: integration test nits (#583) * test: more coverage on splitter tests (#594) --------- Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> * fix: add missing operator fee vault field (#616) * feat: invariants and tests (#595) * fix: ir informationals (#609) * fix: pre pr (#622) * refactor: use cdm (#624) * fix: update withdrawal gas limit value on check (#627) * fix: remove rev share field from deploy op chain input struct (#628) * refactor: remove initializer and vaults getter changes (#631) * fix: remove immutable check over vaults (#634) Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com> * fix: audit findings (#658) * fix: pre pr * feat: add user guide docs for rev sharing on op deployer (#666) * docs: add create2 comment (#667) --------- Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com> * Add DeployFeesDepositor script (#18223) * Add DeployFeesDepositor script * Refactor deploy script to remove Output struct * forge fmt * Make logResults() pure * fix return value names * remove unused import * Apply suggestions from code review Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * Add missing natspec * Add natspec to tests --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * feat: add superchain ops upgrader audit report * chore: rename upgrader audit report * fix: proper report naming * feat: add audit report * chore: update report with audit fixes commit hash * fix: rename audit report on readme * chore: add l2 splitter contracts on version name --------- Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com> Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com> Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com> Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com> Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com> Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com> Co-authored-by: Maurelian <john@oplabs.co>
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Jan 28, 2026
* sysext: correctly populate address configuration (#17771)
sysext was previously using the L1Address field from the devnet-env.json,
which netchef does not use. We remove this field to prevent future
confusion and switch to the correct `Address` field.
* op-devstack: give more time for l2 to include bridge tx (#17772)
in persistent devnets with longer block times, it can take longer
than the previously-configured 60 seconds, leading to timeouts and flakes.
* op-acceptance-tests: fix test due to geth breakage (#17757)
* op-acceptance-tests: fix test due to geth breakage
geth changed the value of params.HistoryServeWindow and it broke the test.
https://github.com/ethereum/go-ethereum/pull/32127
* op-acceptance-tests: avoid failing when we can wait
* feat: fix test eth amounts to be smaller (#18044)
* ctb: Skip blueprint DG impl verification (#18054)
* ctb: Skip blueprint DG impl verification
When the deploy dipuste game v2 feature flag is enabled, we should skip
verification of the old v1 implementation blueprints
* assert zero-valued blueprint address
* fix typo
* cannon: Default to cannon VM version 8 (#18062)
* Bump 'current' cannon vm to version 8
* Update docker diff check
* Always build "next" version of cannon
* tests: Non-zero prestate when running DeployDisputeGame (#18057)
* devstack: Enable individual dev features instead of replacing the whole bitmap (#17994)
Allows things to be combined easily and avoids the risk of features being left disabled because they were later overwritten.
* op-acceptance-tests: fix two papercuts (#18067)
- spammer schedules emit warning logs too often.
- DA footprint test does not retry while looking for an L1 origin often enough.
The root problem (arbitrary timeouts everywhere) can be addressed later.
* cannon: Include state version in witness output (#18068)
* chore: Go cache for several uncached builds (#18056)
* chore: Go cache for several uncached builds
* chore: Comment
* chore: Fix modules for cache
* fix: Don't cache fuzz tests
* chore: Restore cache for make-fuzz
* chore: Better parallel output
* chore: Restore cache namespace
* fix: Typo
* refactor: remove redundant error checks in deriver (#18069)
* cannon: Rework cannon "next" vm handling in e2e tests (#18064)
* Revert "Always build "next" version of cannon"
This reverts commit 71ea70199d2227ea1d0c7f83298bb9abd3acadb3.
* Only use 'next' cannon prestate if it differs from the current prestate
* op-service/apis: remove redundant interface (#18049)
* forklive: Use v2 DG ABI accordingly (#18065)
* feat: cleanup contracts CI and properly run dev feature tests (#18051)
* feat: run dev features thru normal tests
* fix: test suite names
* fix: skip test for v2 dispute game feature
* fix: build go ffi
* fix: build source before coverage tests
* op-devstack: fix TestSubProcess flake (#17815)
The caller of cmd.StdoutPipe() must finish reading from the returned
io.ReadCloser before calling cmd.Wait(), otherwise not all of the
logs will be read. This is a race condition that resulted in
occasional test flakes.
This commit fixes the buggy test and removes a lot of unnecessary code
in the process.
* Enable monitoring in sysgo (#18017)
* WIP
- Passing metrics env vars through in l2_cl_kona
- Added L2MetricsDashboard sysgo lifecycle component
* Documenting and wiring up L2MetricsDashboard
Also adds some util unit tests
* Adding op-reth metrics support
Also:
- Updates README with more useful metrics info
- Fixes error log in l2_cl_kona.go
- Changes default docker exec path to `docker`
- Makes available port util threadsafe
* Updating GetAvailableLocalPort signature
* Adding logging context in kona-node, op-reth, l2 metrics dashboard
* GetEnvVarOrDefault: os.GetEnv => os.LookupEnv to allow for setting ""
* Single env var to enable/disable metrics for all configured components
* Encapsulate vars and functions within sysgo package
* Inline metrics endpoint parsing from logs
* Adding issues to kona and op-reth and referencing in metrics port setting
* Making metrics' subprocesses start/stop in parallel
* Moving PrometheusMetricsEndpoint into l2_metrics_dashboard.go
* Using new L2MetricsRegistrar interface instead of callbacks
Also uses stack.IDWithChain instead of service name
* Simplifying PrometheusMetricsTarget
Still conveys how to interpret the host & port without
storing that on the struct
* Using logger's key-value format where possible
* Handling file close errors when writing metrics configs
* Fixing broken test
* Making metrics url parsing more resilient
* Start/Stop updates
- Removing goroutines from Start
- Blocking on waitgroup in Stop instead of waitgroup or context done
* Removing failure when registering the same endpoint twice
* Removing redundant if
* Unexporting util functions
* Pinning specific versions of prometheus and grafana
Overrides are possible via env vars
* Updating Subprocess.Stop calls after rebase
* op-acceptance-tests: bump spammer budget (#18080)
was seeing lots of insufficient funds errors on Jovian alphanet
* chore(op-acceptance-tests): ci; kurtosis defaults to cci runner (#18083)
* opcm-standard-validator: Add validation for CANNON_KONA games (#18050)
* Add validation input for cannon-kona prestate
* Pass errorPrefix as a parameter to assertValidPermissionlessDisputeGame
* Inject gameType into assertValidPermissionlessDisputeGame
* Add checks for cannon-kona game type
* Cleanup - rename game variables for clarity
* Cleanup: guard logic that is only necessary for v1 games
* Deploy cannon-kona game for standard validator tests
* Update existing test error expectations
* Add CannonKona tests
* Bump contract versions
* Run pre-pr
* Preserve current validation methods and structs
* Run pre-pr
* fix(op-batcher): exempt generic da from max input size (#18074)
* fix(op-batcher): exempt generic da from max input size
* Apply suggestion from @sebastianst
---------
Co-authored-by: Javed Khan <tuxcanfly@gmail.com>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* add `Test_ProgramAction_OperatorFeeFixTransition` (#17925)
* add Test_ProgramAction_OperatorFeeFixTransition
* fix
* undo changes to submodule
* respond to review
* remove proxyAdmin inputs from opcm and sv, derive it from the sysCfg, fix tests (#17744)
* remove proxyAdmin inputs from opcm and sv, derive it from the sysCfg, fix tests
* run semver lock for sv
* remove unused imports
* adapt go code, fix go tests
* fix UpgradeOPChain test
* fix addGameType go test
* use semverComp to make interface usage checks flexible
* fix failing ci
* use better naming for old opcm interfaces and related contracts
* fix go tests
* try fix op-acceptance tests
* finally fix op-acceptance tests?
* update block number in justfile and not do u16a upgrade on tests
* add upgradeSuperchainConfig pkg and add e2e bootstrap test for it upgrade in v5_0_0 pkg
* fix failing upgrade go test, add more upgradeOPChain solidity test
* rm old validate fn from sv interface
* rm unused import
* add unexpectedEncoding revert test and improved assertion to upgradOPChainInput
* fix semgrep
* fix upgradeSuperchainConfig script
* make upgrade test fork a specific block
* update addGameType to support the new opcm addGameType interface
* fix go lint
* fixes
* fixes
* fixes
* fix semver and go lint
* fix go test
* fix go test
* fix go test
* fixes
* fixes for add game type go test
* fixes
* remove outdated test
* pull and fix
* chore: Bump kona version in docker build (#18094)
* ctb: Fix OPCM std validator test setup for v2 DG (#18066)
* ctb: Fix OPCM std validator test setup for v2 DG
* fix typo
* op-deployer: Add flags for new v2 dispute game implementations options (#18027)
* op-deployer: Fix error handling in add_game_type CLI parsing.
Previously it exited with an error message when there was no error.
* op-deployer: Add flags for new implementations options
Also provides standard values as defaults.
* chore(op-acceptance-tests): op-acceptor v3.6.1 (#18086)
* opcm: Add CANNON_KONA support for opcm.upgrade (#18059)
* opcm: Add CANNON_KONA support for opcm.upgrade
* fix sepolia upgrade integration test
* run cannon-kona upgrade in integration test
* remove debugme
* fix stdvalidator.test_init
* fix outdated opcm bindings
* update semver; snapshots
* cleanup setNewGameImplV2
* fix semver; fix natspec
* fix op-deployer Migrate input encoding
* fix nits
* fix semantic merge conflict
* fix fmt
* update semver
* only expect cannon-kona reverts if feature flag set
* op-acceptance-tests: Improve DA footprint test stability (#18098)
* test(contracts): enhance L2ToL1MessagePasser test coverage and organization (#18028)
* fix(test): add missing event expectation in burn test
* refactor(test): remove redundant initiateWithdrawal tests and add nonce assertion
* test(contracts): add coverage for version, receive, messageNonce, and burn edge case
* refactor(test): reorganize test contracts to match source function order
* fix(test): restore removed initiateWithdrawal tests with scenario-specific assertions
* refactor(test): remove redundant zero-balance burn test per review
* refactor(test): remove unnecessary contract code length assertion per review
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* test: enhance OperatorFeeVault test coverage and organization (#18087)
* refactor(test): remove redundant contract name from constructor test
Simplified test_constructor_operatorFeeVault_succeeds to test_constructor_succeeds
to match naming convention used in other FeeVault tests (BaseFeeVault, etc.)
* test(contracts): add version format validation for OperatorFeeVault
Added OperatorFeeVault_Version_Test contract to validate that the version
constant returns a valid semver string using SemverComp.parse()
* refactor(test): reorganize test contracts to match source declaration order
Moved Version_Test before Constructor_Test to match the order in which
version (line 21) and constructor (line 25) are declared in OperatorFeeVault.sol
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* op-deployer: Support working with V2 fault dispute game contracts (#18024)
* op-deployer: Support working with V2 fault dispute game contracts
* Deploying implementations supports the fault dispute game configuration options previously used by deploy dispute game
* DeployDisputeGame has been updated to work with v1 and v2 contracts
* SetDisputeGameImpl works with and without game args
* ReadImplementationAddresses loads the V2 dispute game addresses
* op-deployer: Don't validate inputs set as game args when v2 is enabled.
* op-deployer: Restore absolute prestate check for V1 contracts.
* opcm: Read super dispute game implementation addresses.
* opcm: Allow clock extension to be zero again
* Store permissionedDisputeGame when V2 enabled
* opcm: Restore the clockExtension > 0 check
* op-acceptance-tests: fix operator fee test (#18104)
fails against isthmus networks. Discovered when running against
jovian betanet.
* opcm: Set cannon_kona init bond during upgrade (#18100)
* opcm: Set cannon_kona init bond during upgrade
* address review comments
* op-dispute-mon: node endpoint error metrics (#17622)
* dispute-mon: Add metric to track node endpoint errors
* dispute-mon: Add node endpoint error count metric
* dispute-mon: Add metric for mixed availability of nodes
* dispute-mon: Add metric to track mixed safety
* dispute-mon: Add metric for disagreeing output roots
* Increase log level for mixed availability
* Use better check for RollupEndpointErrors
* Fix test after merge
* Remove useless logging
* Remove unnecessary fields from Service struct
* Remove unused function and lint fix
* mise: Define fake install sources for disabled tools (#18109)
The latest mise (installed by brew) errors if tools don't have a known install source even if they're disabled. While we control the version of mise used in CI, local development depends on an existing mise to bootstrap and there isn't a good way to ensure it is using a specific version.
* remove DeployProxy (#18122)
* remove DeployProxy
* fixes
* all: Move fork names into new op-core/forks package (#18121)
* fix: use default mips version and use local op-deployer (#18129)
* fix: bump mips version from 7 to 8
* fix: don't require building binary to use justfile with correct op-deployer version
* fix: remove mips version arg
* feat: Use build-no-tests in op-deployers just build command (#18130)
* fix(prompt): add guidance to skip unrelated CI failures (#18127)
* feat(ci): run upgrade tests with dev flags (#18133)
* feat(ci): run upgrade tests with dev flags
Updates CI to run upgrade tests with dev flags enabled. Only OP
will run with dev flags enabled for now, this should be sufficient
and will avoid dramatically increasing CI impact.
* fix: correct cannon kona prestate in validator tests
* opcm: Update OPCM.migrate to support Cannon-Kona games (#18078)
* Update opcm.migrate to set super-cannonKona
* Validate cannonKona prestates during migrate
* Update OCPM migrate tests
* Cleanup: add helper to construct gameType expectations
* Fix game validation test logic
* Fix shadowed var warning
* Rework op-deployer migrate CLI args for absolute prestate
* Read cannonKona prestate in GenerateOPCMMigrateCalldata
* Don't create SuperCannonKona game if prestate is zero
* Update migration gameType helper
* Clean up test logic, perform stricter checks on empty games
* Add error messages
* Clear game args when game impl removed
* Add test with empty cannonKona prestate
* Enforce non-empty cannon prestate
* Bump contract version
* Run just pre-pr
* Cleanup and add another test
* Fix test documentation
* Add new prestate flags to the migrate CLI command
* Update script comment with updated sample input
* Add check for consistent permissionless weth contracts post-migrate
* Bump opcm version again
* Run semver-lock
* fix(op-deployer): update justfile to use current CLI flags (#18143)
* all: update op-geth to pull in fusaka and jovian timestamps (#18131)
* all: update op-geth to pull in fusaka timestamps
* update for scr changes
* point go.mod at op-geth rc
* address comment
* op-service/flags: Modularize fork override flags (#18135)
* chore(op-acceptance-tests): op-acceptor v3.6.2 (#18120)
* op-devstack: debug info when L2CL peers connection fails (#18149)
* feat(ctb): Add the nonce and txHash into the ScheduledTransactions struct (#18097)
* feat(ctb): Add the nonce and txHash into the ScheduledTransactions struct
* chore(ctb): bump the semver on SaferSafes
* feat(ctb): txHash at start of struct
* semver-lock
* fix ITimelockGuard to match
---------
Co-authored-by: Alberto Cuesta Cañada <alberto@oplabs.co>
* feat(l3s): Add support for the default finality lookback (#18071)
* chore(op-acceptance-tests): switch to docker executor (#18084)
* all: Move package predeploys from op-service to op-core (#18145)
* all: Move package predeploys from op-service to op-core
* gofmt
---------
Co-authored-by: Adrian Sutton <adrian@oplabs.co>
* Safer Safes audit fixes (no bytecode changes) (#18147)
* Typo
* Fix natspec notice
* `_blockingThreshold` natspec
* Bump the safe nonce when cancelling
* Accepted trade-off
* We allow cancelling transactions from disabled guards.
* Fixed `changeOwnershipToFallback` natspec.
* Updated version and semver-lock
* Typo
* op-acceptance: Add acceptance test for playing out dispute games (#18085)
* op-acceptance: Add acceptance test for playing out dispute games.
* op-acceptance: Wait for step to be called by honest challenger.
* dsl: Make asChallengerClaim private
* dsl: Support posting the root claim of the bottom game.
* Don't need to use permissioned proposals.
* Cache honest trace accessors.
* Review feedback
* fix(op-acceptance-tests): ci; slack token (#18156)
* op-batcher: refactor (#18174)
* op-batcher: embed ChannelBuilder and remove redundant code
* op-batcher: remove dead code
* op-acceptance-tests: Replace fast games with regular FDGs in withdrawal test (#18152)
* fix(op-deployer): increase cliRunner test timeouts (#18179)
* fix(op-deployer): increase cliRunner test timeouts
* add cliRunner logs for debugging help
* contracts: Load CANNON game implementation from DisputeGameFactory instead of via artifacts (#18155)
* contracts: Load CANNON game implementation from DisputeGameFactory instead of via artifacts
* contracts: Load permissionless WETH implementation dynamically
* contracts: Don't attempt to load game args - the updated DisputeGameFactory that supports them isn't available yet.
* challenger: Stop kona-host using color in logs (#18182)
* SaferSafes audit fixes 2 (#18172)
* Missing `indexed` in an event
* Don't allow configuring a non-enabled safe
* Version and semver-lock
* Disallow the safe address as a fallback owner
* Document why we prefer not to revert
* Disallow a timelock delay of zero, use `setGuard(0)` instead.
* lint and semver-lock
* Simpler natspec
* Update test description
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* chore(op-acceptance-tests): flake-shake; test promotions (#18198)
* feat: introduce fee splitter for revenue share (#17536)
* feat: fee splitter system (#469)
----
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
* fix: failing tests (#553)
* refactor: revenue sharing config (#538)
* fix: pre pr and semgrep (#565)
* fix: warnings (#571)
* fix: tests failing on fork environment (#575)
* fix: use encode call on constructors (#578)
* feat: add integration splitter test (#581)
* fix: integration test nits (#583)
* test: more coverage on splitter tests (#594)
---------
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
* fix: add missing operator fee vault field (#616)
* feat: invariants and tests (#595)
* fix: ir informationals (#609)
* fix: pre pr (#622)
* refactor: use cdm (#624)
* fix: update withdrawal gas limit value on check (#627)
* fix: remove rev share field from deploy op chain input struct (#628)
* refactor: remove initializer and vaults getter changes (#631)
* fix: remove immutable check over vaults (#634)
Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>
Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com>
Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
* fix: audit findings (#658)
* fix: pre pr
* feat: add user guide docs for rev sharing on op deployer (#666)
* docs: add create2 comment (#667)
---------
Co-authored-by: Funkornaut <107587461+funkornaut001@users.noreply.github.com>
Co-authored-by: Flux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com>
Co-authored-by: 0xng <87835144+0xng@users.noreply.github.com>
Co-authored-by: Joxess <91908708+Joxess@users.noreply.github.com>
* ci: Use cached solidity compilers (#18140)
Should reduce the likelihood of text file busy errors.
* op-challenger: Support super-kona games (#18184)
* op-node: remove dead code (#18183)
* op-supernode: Runnable and RPC Activities with Heartbeat Example (#18141)
* op-supernode: Runnable and RPC Activities with Heartbeat Example
* Address Changwan's Comments
* fix Makefile Typo
* dispute-mon: new metric to track out-of-sync node endpoints (#18105)
* batch_decoder: Fix & allow config loading via L2 chain ID (#18209)
* op-devstack: remove fetching for cluster depset (#18211)
* refactor(scripts): remove GenerateOPCMMigrateCalldata script (#18212)
* ci: Prepare for kona prestate verification (#18175)
* ci: Prepare for kona prestate verification
* review comments
* add accursed hack
* apply review suggestions
* pipe mise use logs to file
* cannon-kona: Add support for building kona prestate and kona-host (#18144)
* kona: Add a justfile to build a specific version of kona
* Try building on a machine
* Cache properly
* Remove REPO_ROOT
* Build pre-interop and interop kona prestates
* Set the cannon-kona prestate in interop tests.
* ci: Build kona-host
* Test kona-host can execute
* Fix rust image version
* Use two separate machines
* No remote docker for machine executor
* Update rust
* Install clang
* Fix machine config
* Use default docker image since mise is installing rust
* Set kona-host and prestate URL in challenger config
* Remove test-kona step
* Try not installing clang
* Change justfile
* Really force a change
* Back to installing clang
* Restore cannon prestate for kurtosis tests
* Remove forced change var
* Ensure tests that don't use kona can run even if kona components haven't been built.
Add skipped test to actually run cannon-kona game. Doesn't pass yet because kona-host doesn't support ws:// URLs which are used by sysgo.
* Add cannon-kona config for interop challenger.
* Only add cannon-kona games when feature toggle is enabled.
* Use kona v1.2.2
* Fix kona prestate URL
* Only set cannon-kona config for tests that opt-in.
Removes the need for run-kona-host.sh
* op-acceptance-tests: give contract deployer enough eth (#18230)
* op-devstack: refactor how L2 forks are required (#18228)
* remove DeployPreimageOracle scripts (#18151)
* remove DeployPreimageOracle scripts
* try fix go test
* try fix go test
* try fix go test
* fixes
* fixes
* fixes
* fixes
* fix(op-faucet): explicitly define timeouts (#18235)
* fix(op-faucet): explicitly define timeouts
* fix(op-faucet): reduced timeout
* op-e2e: Remove support for L2OO withdrawals (#18201)
op-e2e hasn't had a configuration that used L2OO for a long time so remove the code paths to perform withdrawals pre-fault proofs.
* cannon: Fix shutdown process to ensure preimage server channels are closed (#18229)
* cannon: Fix shutdown process to ensure preimage server channels are closed
kona-host wasn't exiting when the client program completed leaving cannon hung forever.
Closing the file channels sends a signal it actually listens to so it exits.
Also strengthen the fallbacks to ultimately terminate the subprocess forcefully if it ignores even the KILL signal.
* cannon: Remove Signal(Kill) since the Kill method just does that.
* fix(op-acceptance-tests): flake-shake; guard against empty tests. (#18238)
* op-acceptance-tests: run Jovian tests against Pectra and BPO2 (#18005)
* op-acceptance-tests: run Jovian tests against Pectra and BPO2
* fix bug?
logs
* fix it for real this time
* op-devstack: err on malformed multiaddr (#18240)
* Debounce FCU Update (#18234)
* chore: General-purpose Github release binary downloader (#18245)
* chore: Github release binary provider
* fi: Untar
* chore: Comments
* refactor(prompt): remove unnecessary test reordering by source function order (#18248)
* Recommended a Safe fallback owner (#18239)
* chore: Get rid of latitude-1 boxes (#18251)
* chore: Blobless checkouts for some jobs (#18249)
* Enhance Hashing library test coverage and quality (#18195)
* test(contracts): enhance Hashing library test coverage and quality
- Convert hashDepositSource test to fuzz test for broader coverage
- Add harness function for hashCrossDomainMessage to enable proper revert testing
- Add test for hashCrossDomainMessage unknown version revert case
- Add comprehensive test for hashL2toL2CrossDomainMessage function
- Ensure all public functions have test coverage
- Maintain test contract organization matching source function order
* test(contracts): restore original hashDepositSource test as known vector
- Add test_hashDepositSource_knownVector_succeeds alongside fuzz test
- Preserves original test case (0xd25df7858efc1778118fb133ac561b138845361626dfb976699c5287ed0f4959, 0x1)
- Addresses reviewer concern about maintaining historical test coverage
- Both fuzz test and known vector test now pass (11 total tests)
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* contracts: ReadImplementations output include AnchorStateRegistry + Opcm components (#18241)
* fix(ci): publish-contract-artifacts disable parallel composite upload (#18236)
* fix(ci): publish-contract-artifacts disable parallel composite upload
* add explanatory comment
* ci: move publish-contract-artifacts from latitude to circleci runner
* op-node: Capture driver start log (#18254)
* fix(ci): bump machine size for publish-contract-artifacts (#18257)
* doc: add contract release checklist requirement (#18242)
* doc: add contract release checklist requirement
* Link to finalizing section
---------
Co-authored-by: Maurelian <maurelian@protonmail.ch>
* chore: Drop code persistence from the CI workflows (#18259)
* chore: Drop code persistence
* chore: Install contract dependencies & attach workspace
* chore: Acceptance tests
* chore: Last two latitude boxes gone (#18260)
* chore: Last two latitude boxes gone
* chore: Bump the resources
* fix(contracts-script): adds support for zstd scripts (#18237)
* fix(contracts-script): adds support for zstd scripts
* fix(contracts-script): missing extract support
* fix(op-service): tar transversal attack protection
* fix(op-service): zstd installation as a command
* fix(op-service): pin zstd
* test(contracts): enhance RLPWriter test coverage and organization (#18119)
* test(contracts): enhance RLPWriter test coverage and organization
- Add fuzz test for writeUint to test broader range of values
- Add comprehensive test coverage for writeAddress function
- Add comprehensive test coverage for writeBool function
- Reorganize test contracts to match source function declaration order
(writeList, writeString, writeAddress, writeUint, writeBool)
All 31 tests passing with improved coverage for previously untested functions.
* refactor(tests): undo RLPWriter test file reordering per reviewer feedback
Restore original test contract order (writeString → writeUint → writeList)
to reduce diff size as requested by reviewer. New test contracts for
writeAddress and writeBool are appended at end of file. No functional
changes to existing tests - only reordering.
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* op-e2e: Only deploy the fast game in AllocTypeFastGame (#18263)
* op-e2e: Only deploy the fast game in AllocTypeFastGame
Use the fast game alloc in withdrawal tests and not in alphabet tests.
Actually make the fast game fast.
* op-e2e: Use fast games for another withdrawal test
Setup proposer to create permissioned games if fast games aren't enabled.
* op-supernode: Enable P2P for Virtual Nodes (#18213)
* op-supernode: Enable P2P for Virtual Nodes
* remove unit test for disabled p2p
* op-acceptance: Remove work around that creates a "fresh" L2 user (#18265)
* chore(op-acceptance-tests): op-acceptor v3.6.6 (#18266)
Updates op-acceptor to [v3.6.6](https://github.com/ethereum-optimism/infra/releases/tag/op-acceptor%2Fv3.6.6).
* op-node: update OnUnsafeL2Payload to perform ELSync gap filling (#17751)
* op-node: update OnUnsafeL2Payload to handle ELSync
* op-node: add SyncModeReqResp flag
* op-devstack, op-e2e: add SyncModeReqResp=true to keep current behavior
* op-acceptance-tests: matrix for SyncModeReqRespSync and ReqRespSyncDisabled
* fixup
* op-node: change default value for --syncmode.req-resp to true
* Apply suggestion from @pcw109550
Co-authored-by: Changwan Park <pcw109550@gmail.com>
* updated debug logs
* add checks for EL sync alongside CL sync checks
* Update op-devstack/sysgo/l2_cl.go
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* Update op-node/rollup/driver/sync_deriver.go
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* Update op-acceptance-tests/tests/sync/clsync/gap_clp2p/sync_test.go
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* address review comments from seb
---------
Co-authored-by: Changwan Park <pcw109550@gmail.com>
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* test(contracts): improve RLPReader test coverage and organization (#18232)
* test(contracts): add comprehensive test coverage for RLPReader library
- Add RLPReader_ToRLPItem_Test contract with tests for empty bytes revert and valid conversions
- Add RLPReader_ReadRawBytes_Test contract with tests for various RLP item types
- Reorganize test contracts to match source function declaration order (toRLPItem, readList, readBytes, readRawBytes)
- Rename test contracts to PascalCase for consistency (ReadList_Test, ReadBytes_Test, ReadRawBytes_Test)
- All 45 tests passing with improved coverage for previously untested functions
* refactor(test): restore original test contract order and naming
- Restore original order: readBytes_Test, readList_Test (then new tests)
- Restore original lowercase naming: readBytes_Test, readList_Test
- Keep new test coverage: ToRLPItem_Test, ReadRawBytes_Test
- All 45 tests still passing
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* op-node: Fix PeekUnsafePayload Test name (#18268)
* chore: Ensure go 1.25.4 compatibility (#18247)
* chore: Update go
* debug: Disable go deps
* chore: reenable abigen
* chore: reenable geth
* chore: reenable mockery
* chore: Replace go deps with binaries
* chore: Replace golangci-lint
* chore: Revert mockery version
* chore: Revert mockery version
* chore: Mockery updates
* chore: Mockery updates
* chore: Revert go version
* debug: Why
* chore: Use default golangci-lint
* debug: Back
* docs(graphite): add vm.expectRevert low-level call pattern rule (#18272)
* docs(graphite): add vm.expectRevert low-level call pattern rule
* docs(graphite): flag missing assertions on vm.expectRevert low-level calls
* ci(contracts): increase heavy-fuzz job resources to 2xlarge (#18276)
* feat: contracts changes required for OPCMv2 (#18244)
* feat: contracts changes required for OPCMv2
* fix: upgrade asr in OPCM
* fix: add ASR tests
* fix: test names
* all: upgrade op-geth (#18280)
* op-dispute-mon: Rename L2BlockNumber to L2SequenceNumber (#18278)
The field is used for both block numbers with output root games and timestamp for super root games.
* temp(ci): reinstate the initialize job for the release workflow (#18284)
* temp: reinstate the initialize job for the release workflow
It just echoes a message and is configured with the correct tag and
branch filters.
* fix echo
* add requires --initialize to subsequent jobs in release workflow (#18285)
* op-devstack: DSL: Configurable attempts for EL NotAdvanced (#18286)
* fix: update expected SuperchainConfigProxy impl and conditionally update it (#18293)
* fix: updated expected SuperchainConfigProxy impl after U17 sepolia upgrade
* fix: conditionally update superchainConfig
* op-challenger: Update version of kona-host in docker image to 1.2.2 (#18231)
* op-challenger: Update version of kona-host in docker image to 1.2.2
* ci: Attempt to create a single source of truth for the kona version
* sysgo: Fix typos
* kona: Update to 1.2.4 (#18302)
* kona: Update to 1.2.4
* kona: Enable challenger acceptance test
* kona: Delete bin dir when cleaning
* kona: Fix key for kona-host cache
* ctb: Fix DisputeGameFactory fuzz tests (#18296)
* cannon: Add go 1.25 tests (#18279)
* cannon: Add go 1.25 tests
* cannon: Use go 1.25.4 for tests.
Simplify and actually run the keccak tests.
* op-e2e: Deflake TestMissingBatchE2E: Retry inclusion check when indexing (#18304)
* op-e2e: Deflake TestMissingBatchE2E: Retry inclusion check when indexing
* use ticker
* handle timeout err
* test(contracts): add version validation test for WETH contract (#18303)
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* build(contracts): enforce compiler warnings and fix test return value checks (#18264)
* build(contracts): enforce compiler warnings as errors
- Add deny_warnings to foundry.toml default profile
- Add set -e to pre-pr command in justfile
* test(contracts-bedrock): fix unchecked low-level call return values in FeeSplitter tests
- add proper return value checks for low-level .call() operations
- fix Warning 9302 in FeeSplitter.t.sol (3 occurrences)
- fix Warning 9302 in FeeSplitterVaults.t.sol (1 occurrence)
* build(contracts): ignore too-many-warnings error in foundry config
* fix(test): fix assertion logic in FeeSplitter expectRevert tests
- remove assert(!success) after vm.expectRevert() calls
- add success variable reference to suppress unused variable warning
* ci(contracts): add latest artifact fallback to reduce PR build times (#18291)
* ci(contracts): add latest artifact fallback to reduce PR build times
- upload artifacts with "latest" name in addition to checksum-based name in publish-artifacts.sh
- add --fallback-to-latest flag to pull-artifacts.sh
- enable fallback logic to try artifacts-v1-latest.tar.{gz,zst} when exact checksum not found
- update contracts-bedrock-tests job to use --fallback-to-latest flag
- update contracts-bedrock-coverage job to use --fallback-to-latest flag
- update contracts-bedrock-tests-upgrade job to use --fallback-to-latest flag
* refactor(script): extract download_and_extract helper in pull-artifacts
* fix(scripts): prevent path traversal in artifact extraction
* revert: remove pull-artifacts.sh and CI config changes for phased rollout
* Add logfmtms to Log Format Usage (#18297)
* cannon: Fix support for state version 7 in latest docker builds (#18311)
Latest cannon now only supports state version 8, so ensure we use an older cannon for state version 7 when building multicannon.
* cannon: Ensure cannon temp files are removed before exiting. (#18312)
os.Exit doesn't run defer statements before exiting. So return cli.Exit error instead - still lets us set the error code and triggers an exit, but handled by urfave after the function has returned and defer statements have run.
* op-node: Light CL: Frontend Flags (#18270)
* op-node: Light CL: Frontend Flags
* better go
* op-node: Move unsafeOnly related logs to init
* Removed default values for optional flags
* Use IsSequencer instead of isVerifier on syncCfg check
* Early fail by checking invalid flag combinations
* Better logs for unsafe and safe status
* feat: setBatcherHash address overload (#18298)
* feat: setBatcherHash address overload
* chore: semver
* fix: Artifact publishing script (#18275)
* op-sync-tester: Verifier Engine APIs for Jovian (#18307)
* op-acceptance-tests: Include Jovian for Sync Tester HF tests
* op-sync-tester: Support Jovian
* Fix sync tester extra data validation
* Check safe only advancement
* fix comment
* Disable discovery because we cut the CLP2P manually
* ci(contracts): enable latest artifact fallback logic (#18310)
* ci(contracts): enable latest artifact fallback logic
- add --fallback-to-latest flag to pull-artifacts.sh
- enable fallback forcontracts tests, coverage, and upgrade jobs in ci config
- extract download_and_extract helper function in pull-artifacts.sh
- add path traversal protection with --exclude='*../*' flag to tar commands
* test: trigger artifact fallback by modifying test file
* fix(scripts): address bots security concerns in pull-artifacts.sh
- add secure curl flags (--fail, --location, --connect-timeout, --max-time, --tlsv1.2) to prevent hangs and enforce TLS
- update path traversal exclusion pattern from '*../*' to '*..*' to block all paths containing '..' anywhere
- revert test comment change used for CI testing
* op-deployer: record opDeployerVersion in intent and state (#18333)
* docs: add cgt audit report (#18328)
* docs: add cgt audit report
* Update docs/security-reviews/README.md
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
---------
Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
* all: upgrade op-geth (#18214)
* lsp fixes
* update go versions, delete cannon go1.23 modules
* remove dead code that was panicking
* go mod tidy in cannon modules
* op-program: Update baseline cannon report
* update geth to synctest tag
---------
Co-authored-by: inphi <mlaw2501@gmail.com>
* circleci: Slack context for scheduled-sync-test-op-node (#18341)
* op-chain-ops: add check-jovian cmd (#18269)
* op-chain-ops: add check-jovian cmd
* op-chain-ops: add extra data format validation to check-jovian command
* op-chain-ops: enhance block header validation in check-jovian command to differentiate between zero and non-zero BlobGasUsed
* refactor using op-geth library fns
* Rename checkBlockHeader to checkBlock and improve Jovian activation
checks
* Add secret-key flag to send tx-to-self
When a hex secret key is supplied, send a signed tx-to-self on L2, wait
up to 2 minutes for it to be mined, and use its block for the
BlobGasUsed check. Normalize 0x prefix and surface errors on failure.
* lint
* Require non-zero BlobGasUsed for Jovian
* Use txmgr to send and wait for tx in check-jovian
Replace manual key parsing, signing, and bind.WaitMined with a
SimpleTxManager (txmgr). Add l2endpoint to env and wire txmgr config,
using txmgr.Send to submit and await the self-transfer receipt.
* Validate BlobGasUsed against DA footprint
* Use provided context for transaction send
* Update op-chain-ops/cmd/check-jovian/main.go
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* Remove comment about BlobGasUsed
* Document secret key option for check-jovian
Add usage examples for CHECK_JOVIAN_SECRET env var and the --secret flag
* Return error on zero DA scalar; harden blobGasUsed
Treat a DA footprint gas scalar of 0 in L1Block as an error (Jovian
should not allow it). Delay calling t.From() until after creating the tx
manager and check the BlobGasUsed pointer before dereferencing to avoid
nil derefs.
* Annotate txmgr logger with component field
* Return error for blocks with no transactions
Treat blocks with zero transactions as an error instead of proceeding.
Retain the inconclusive warning for single-transaction blocks. Compute
DA footprint only for blocks with multiple transactions.
---------
Co-authored-by: Sebastian Stammler <seb@oplabs.co>
* test(contracts): add comprehensive test coverage for Constants library (#18267)
- Split EIP1967 constants test into separate tests for better clarity
- Add tests for ESTIMATION_ADDRESS, DEFAULT_L2_SENDER, GUARD_STORAGE_SLOT, ETHER, and DEPOSITOR_ACCOUNT constants
- Add test for DEFAULT_RESOURCE_CONFIG() function covering all 6 struct fields
- Import IResourceMetering interface for ResourceConfig struct testing
All 8 tests pass successfully.
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* test(contracts): enhance LegacyMessagePasser test coverage with fuzz tests (#18340)
* test(contracts): convert passMessageToL1 test to fuzz test
- Convert test_passMessageToL1_succeeds to testFuzz_passMessageToL1_succeeds
- Fuzz both message content and sender address for broader coverage
- Fix assertion to use assertTrue() instead of assert()
* refactor(test): improve test naming and validation
- Rename testFuzz_passMessageToL1_succeeds to testFuzz_passMessageToL1_arbitraryInput_succeeds
- Add message length bound (4096 bytes) to prevent out-of-gas in heavy-fuzz CI
- Add negative assertion to verify per-sender separation
- Rename test_version_succeeds to test_version_validFormat_succeeds
- Replace hardcoded version check with format validation (non-empty + 2 dots)
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* feat(op-validator): add v5.0.0 contracts support (#18299)
* feat(op-validator): add v5.0.0 contracts support
* fix(op-validator): lint
* fix(op-validator): disable 5.0.0 in tests
* fix(op-validator): detect validatoraddress
* fix(op-validator): add comments
* fix(op-validator): use semver to compare
* feat: expose starting root in ASR (#18343)
* feat: expose starting root in ASR
* fix: have function expose struct
* fix: bump circleci image size
* fix: bad test for upgrades
* Enforce deterministic shell script formatting with shfmt (#18329)
* Add shfmt
Fix .editorconfig
* apply formatting with shfmt
* feat: add op-succint contracts (#18277)
* feat: add op-succint contracts
* feat: add types and errors for op-succinct contracts
* fix: some types and OutputRoot -> Proposal
* fix: import errors
* fix: l2Blocknumber to l2SequenceNumber
* fix: remove unused import
* fix: interface compiler version, naming, and semgrep fixes for ci
* Update packages/contracts-bedrock/src/dispute/lib/Types.sol
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* fix: build error for types file
* chore: bump semver lock
* chore: bump semver after conflict
* fix: bump semver lock
* fix: ignore new contract in initializer tests
* docs: add attribution
* fix: bump semver lock
* fix: bump semver
* fix: bump semver
* fix: bump semver lock
* chore: semver lock got hands
* fix: semver lock
* fix: semver lock
* fix: semver lock
* fix: semver lock
---------
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* fix(ci): add branch restriction and label override for artifact fallback (#18330)
* fix(ci): restrict artifact latest fallback to PRs only
- add branch check to only use --fallback-to-latest on non-develop branches
- ensure develop merges build with fresh artifacts
* feat(ci): add force-use-fresh-artifacts label override for artifact fallback
* fix(ci): replace gh cli with curl for label check
* refactor(ci): extract artifact fallback logic to bash script
- move conditional logic from circleci config to use-latest-fallback.sh
* fix(ci): add security flags to curl in use-latest-fallback.sh
* fix(ci): use jq instead of grep for json parsing
* fix(ci): add error handling for github API failures
- wrap curl and jq calls in conditional to catch failures
- default to fallback behavior if API call fails (safe default)
- log warning message when API is unreachable
* SystemConfig: Parse L1 Receipts Atomically Before Application (#18292)
* SystemConfig: Parse L1 Receipts Atomically Before Application
* Change Apply rules to all Valid ; PR Comments
* Add indicies back to error
* fix(op-acceptance-tests): reduce per-package timeout (#18349)
* op-node/rollup/derive: Fix too old batch epoch handling (#18283)
* fix(ci): add dependency installation to heavy fuzz nightly job (#18351)
- add install-contracts-dependencies step in contracts-bedrock-heavy-fuzz-nightly job
* feat(op-deployer): forge verify (#18096)
* feat(op-deployer): forge verify
* fix(op-deployer): state.json verification
* fix(op-deployer): test and lint
* fix(op-deployer): add apply step with validation (disabled)
* fix(op-deployer): add detection for partial verification
* fix(op-deployer): update address
* fix(op-deployer): comments
* fix(op-deployer): test
* fix(op-deployer): make logging debug
* fix(op-deployer): comments
* fix(op-validator): add todo
* chore(ci): op-e2e-cannon-tests; xlarge machine (#18359)
Job kept being killed, probably due to hitting resource limits.
* feat: cgt (#18076)
* feat(cgt): custom gas token
Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com>
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Co-authored-by: Ashitaka <96790496+ashitakah@users.noreply.github.com>
Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com>
* feat: add gasPayingTokenName and gasPayingTokenSymbol on json config files
* fix: contracts semver
* fix: remove system config bool
* test: add OptimismPortal2CGT tests
* chore(cgt): set cgt flag l1block & fixes
* fix(linter): resolve goimports formatting issue
* feat: add separate l2 contracts for cgt (#530)
* feat: add L1BlockCGT
* feat: add L2ToL1MessagePasserCGT
* chore: remove test exclution in test validation
* test(cgt): fix failing tests (#529)
* test(cgt): fix failing tests
* test(cgt): fix portal version
* test(cgt): skip tests on forked mode
* fix: predeploys test cgt mismatch
* test(cgt): minor fixes
---------
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
* fix(cgt): revert weth
* cgt: feature flag integration
Updates the implementation to use the new feature flagging system
* config: make backwards compatible
Use the legacy config name so that less needs to change for legacy CGT
chains
* fix: build issue
Remove leftover merge conflict
* fix: better backwards compatibility
* build: fix
* lint: fix
* snapshots: update
* op-deployer: apply test with CGT
Add a specific test for CGT in the intent
* contracts-bedrock: fix versioning
* lint: fix
* deployer: remove standard values
* contracts: semver lock
* contracts-bedrock: fix semver + abis
* cgt: solidity test cleanup
* solidity: fmt
* tests: remove dead imports
* tests: fixup
* cgt: configurable liquidity amount
* feat: configurable native asset liquidity balance
Fix the build for this feature
* cleanup: merge L1Block logic so that we inherit
Keeps it simple because development on Jovian is happening and we will
inherit any Jovian modifications automatically
* snapshots: update
* cgt: inherit logic for L2ToL1MessagePasser
Generally simplifies the code
* semver-lock: update
* lint: fix
* lint: fixup
* interfaces: fix
* fixes: smol
* deploy-config: sane default
* lint: fix
* linting: fix
* lint: fix
* semgrep: fix
* lint: fix
* tests: fix
* tests: fix fuzz
* fix: custom gas token rebase (#17484)
* fix: import in OptimismPortal2CGT test and pre-pr
* fix(cgt): add missing native asset amount (#543)
* fix: upgrade contract name
* feat: add nativeAssetLiquidityAmount to config json files
* fix: add correct nativeAssetLiquidityAmount in op-deployer
* fix: add correct nativeAssetLiquidityAmount in op-e2e and fix withCustomGasToken argument on op-devstack
* fix: restore OptimismPortal2CGT
* fix: all comments
* fix: comments
* fix: governace
* fix: remove aux
* fix: remove aux
* fix: deploy cgt
* fix: revert cgt deploy config
* fix: deploy config
* chore: run linter
* fix: remove unnecessary GetNativeAssetLiquidityAmount
---------
Co-authored-by: Ashitaka <ashitaka@defi.sucks>
Co-authored-by: agusduha <agusnduha@gmail.com>
Co-authored-by: hexshire <hex@wonderland.xyz>
* fix: l2 genesis pipeline (#554)
* fix: add nativeAssetLiquidityAmount in e2e apply test (#555)
* fix: failing test
---------
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Co-authored-by: Ashitaka <ashitaka@defi.sucks>
Co-authored-by: hexshire <hex@wonderland.xyz>
Co-authored-by: Hex <165055168+hexshire@users.noreply.github.com>
* fix: semver lock
* fix: CGT review fixes (#17534)
* fix: json default zero
* feat(cgt): add native asset liquidity amount test & omitempty on cgt struct
* test: check native asset liquidity amount is correctly configured
* feat: add omitempty to name and symbol on cgt intent struct
* fix: check value in cgt
* feat(cgt): add cgt dev feature
* feat: add cgt dev feature
* refactor: set custom gas token (#563)
* feat: add cgt devFeatures and remove useCustomGasToken from DeployOPChainInput
---------
Co-authored-by: Hex <165055168+hexshire@users.noreply.github.com>
* fix: ir informational
* fix: informational
* fix: legacy tag
* feat(cgt): add setNativeAssetLiquidityAmount & L2Genesis max amount check
* feat: add setNativeAssetLiquidityAmount & L2Genesis max amount check
* test: fix bound param in liquidity controller
* fix: remove unused import
* refactor: move max amount check inside setNativeAssetLiquidity
* refactor: make chainIntent.CustomGasToken a non-pointer (#574)
* refactor: make chainIntent.CustomGasToken a non-pointer
* test: fix custom gas token text (#576)
---------
Co-authored-by: Hex <165055168+hexshire@users.noreply.github.com>
* fix: undo tests
Co-authored-by: hexshire <hex@wonderland.xyz>
* fix: cgt portal (#577)
* fix: semver
* fix: cgt tests coverage (#582)
* fix: l2genesis expectRevert amount test
* test: improve l1block coverage
* test: improve l1blockcgt coverage
* test: add isCustomGasToken tests on SystemConfig
* test: improve L2ToL1MessagePasserCGT coverage
* test: improve L2ToL1MessagePasser coverage
* fix: naming pre-pr
* fix(cgt): change L2ToL1MessagePasser & OPContractsManager semver (#584)
* fix: change L2ToL1MessagePasser semver
* fix: change L2ToL1MessagePasser & OPContractsManager semver
* fix: cgt feature tests (#585)
* fix: cgt feature tests
* fix: deposits with amount 0 when cgt enabled
* Revert "fix: deposits with amount 0 when cgt enabled"
This reverts commit 8bee464d45cf7d4040c4dd1459ffc78de2508024.
* fix: cgt portal (#587)
* fix: ci fixes (#588)
---------
Co-authored-by: Ashitaka <96790496+ashitakah@users.noreply.github.com>
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Co-authored-by: Hex <165055168+hexshire@users.noreply.github.com>
Co-authored-by: hexshire <hex@wonderland.xyz>
* fix: semver
* fix: opcm version
* fix: tests
* feat(op-acceptance-tests): add acceptance tests for native CGT across L1/L2 (#17451)
- Gate suite via L1Block.isCustomGasToken(); assert name/symbol non-empty
- L2: value transfer pays CGT token (typed amounts via op-service/eth)
- L2: XDM rejects callvalue; L2StandardBridge legacy withdraw reverts
- L1: Portal receive/deposit rejects ETH; introspect SystemConfig addr
- L1: assert SystemConfig.isCustomGasToken() is true
* fix: custom gas token rebase review comments (#17577)
* chore: use w3 library
* fix: msg error
* refactor(cgt): rename amount & add geq 0 check (#600)
* feat: add NativeAssetLiquidityAmount sign check
* refactor: rename NativeAssetLiquidityAmount to InitialLiquidity
* refactor(cgt): rename json nativeAssetLiquidityAmount to initialLiquidity (#601)
* refactor: rename json nativeAssetLiquidityAmount to initialLiquidity
* fix: only add initialLiquidity to cgt intent struct
---------
Co-authored-by: Hex <165055168+hexshire@users.noreply.github.com>
Co-authored-by: Ashitaka <96790496+ashitakah@users.noreply.github.com>
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
* fix: cgt review (#17612)
* refactor: replace enableCustomGasToken with cgt devfeature
* feat: remove fund in NativeAssetLiquidity (#605)
* fix(cgt): remove OptimismPortal2 test from exclusions (#606)
* fix: remove OptimismPortal2 test from exclusions
* fix: remove virtual and restore constructor in portal test
* refactor: use low level call to receive test
* refactor(cgt): migrate L1Block and L2ToL1MessagePasser cgt tests (#608)
* refactor: migrate L1Block cgt tests
* refactor: migrate L2ToL1MessagePasser cgt tests
* fix: comments (#607)
* fix: comments
* fix: custom error
* fix: errors and tests
* fix: errors and tests
* fix: cgt tests (#610)
* fix: comments
* fix: custom error
* fix: errors and tests
* fix: errors and tests
* fix: tests
* fix: tests
* fix: weth
* fix: cgt tests (#611)
* fix: comments
* fix: custom error
* fix: errors and tests
* fix: errors and tests
* fix: tests
* fix: tests
* fix: weth
* fix: remove types
* fix: coverage tests (#612)
* fix: separate setUp function tests (#613)
---------
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Co-authored-by: Ashitaka <96790496+ashitakah@users.noreply.github.com>
* test: custom gas token invariants (#17489)
* test(inv): setup and total sup inv
* test(inv): accounting invariants
* chore: doc
* fix: import in OptimismPortal2CGT test and pre-pr
* fix(cgt): add missing native asset amount (#543)
* fix: upgrade contract name
* feat: add nativeAssetLiquidityAmount to config json files
* fix: add correct nativeAssetLiquidityAmount in op-deployer
* fix: add correct nativeAssetLiquidityAmount in op-e2e and fix withCustomGasToken argument on op-devstack
* fix: restore OptimismPortal2CGT
* fix: all comments
* fix: comments
* fix: governace
* fix: remove aux
* fix: remove aux
* fix: deploy cgt
* fix: revert cgt deploy config
* fix: deploy config
* chore: run linter
* fix: remove unnecessary GetNativeAssetLiquidityAmount
---------
Co-authored-by: Ashitaka <ashitaka@defi.sucks>
Co-authored-by: agusduha <agusnduha@gmail.com>
Co-authored-by: hexshire <hex@wonderland.xyz>
* fix: l2 genesis pipeline (#554)
* fix: add nativeAssetLiquidityAmount in e2e apply test (#555)
* fix: failing test
* chore: doc
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* chore: remove unused imports
* chore: fix semgrep
* chore: change error name
---------
Co-authored-by: drgorillamd <83670532+drgorillamd@users.noreply.github.com>
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Co-authored-by: Ashitaka <ashitaka@defi.sucks>
Co-authored-by: agusduha <agusnduha@gmail.com>
Co-authored-by: hexshire <hex@wonderland.xyz>
Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com>
Co-authored-by: Hex <165055168+hexshire@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* refactor: use skipIfDevFeatureDisabled for cgt predeploys test (#614) (#17621)
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
* fix: tests
* fix: auth minter helper & bound _mint in depositTransaction tests (#17642)
* refactor: auth minter helper tests (#618)
* fix: bound _mint correctly in depositTransaction test function (#619)
* chore: run pre-pr
* chore: address ci errors
* chore: fix go tests
* chore: run checks
* test(wip): fix failing tests
* chore: run pre-pr
* fix: cgt flag tests
* test: skip fee split invriant when CGT enabled
* test: fix l2 genesis override test (#673)
* feat: add ownable liquidity (#671)
* feat: add ownable liquidity
* feat: remove enable and add default liquidity
* feat: pre pr fixed
* fix: initializer
* fix: comments
* fix: comments
* fix: pre-pr
* fix: override
* fix: tests
* fix: cursor issues
* fix: cursor bug bot
* fix: cursor bot
* fix: remove override
* fix: comment
* feat: add checks
* fix: tests
* fix: nil in cgt config
---------
Co-authored-by: agusduha <agusnduha@gmail.com>
* fix: semver
* test: fix cgt fork tests (#676)
* test: fix cgt fork tests
* fix: remove dev flag in L1 tests
* fix: go linter (#679)
* fix: go linter
* fix: with custom gas token func
* test: fix go fuzz (#680)
* fix: cgt config jsons (#681)
* fix: zero owner and sepolia address (#685)
* feat: predeploys (#684)
* fix: predeploys
* fix: predeploys
* fix: L2 genesis
* test: fix cgt with revenue sharing tests (#691)
* fix: semver
* fix: cgt liquidity controller natspec (#694)
* fix: remove dev feature flag from opcm (#695)
* fix: remove dev feature flag from opcm
* fix: lint
---------
Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com>
Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Co-authored-by: Ashitaka <96790496+ashitakah@users.noreply.github.com>
Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Ashitaka <ashitaka@defi.sucks>
Co-authored-by: agusduha <agusnduha@gmail.com>
Co-authored-by: Stefano Charissis <stefano@oplabs.co>
Co-authored-by: Simon Something /DrGoNoGo <83670532+simon-something@users.noreply.github.com>
Co-authored-by: drgorillamd <83670532+drgorillamd@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
* fix(scripts): skip validation for missing test artifacts (#18367)
* fix(scripts): skip validation for missing test artifacts
- add extractTestFileName() to extract test filename from artifact path
- add testFileExists() to check if test source file exists recursively in test directory
- skip validation in processFile() when test source file does not exist
- add TestExtractTestFileName test
- add TestTestFileExists test with subdirectory validation
- update TestProcessFile to create test source file and artifact structure
- add setupTestDir() helper function for test directory setup
- add createTestArtifact() helper function for artifact creation
- refactor test setup to use helper functions in 5 tests
* fix(script): skip validation for missing test contracts
- add testContractExistsInFile() to check if contract exists in test file
- skip validation in processFile() when test contract not found in source file
- add TestTestContractExistsInFile test
* feat: have heavy-fuzz tests also use dev feature matrix (#18368)
* chore: Github release binary provider: Version check & static cache pather (#18369)
* chore: Promote static cache pather
* chore: Add runtime version check
* feat: OPCM v2 (#18079)
* feat: OPCMv2
* fix: bug in deploying dispute games
* fix: no more opcmv1 changes
* fix: bad interface
* fix: further clean diff
* fix: reduce diff
* fix: undo artifacts diffs
* fix: broken go structs
* fix: opcm output struct ordering
* fix: better tests
* fix: justfile path
* fix: lcov issue
* fix: pr review comments
* fix: pr comments
* fix: rebase tweaks
* fix: contract verification failure
* fix: last few ci issues
* Add DeployFeesDepositor script (#18223)
* Add DeployFeesDepositor script
* Refactor deploy script to remove Output struct
* forge fmt
* Make logResults() pure
* fix return value names
* remove unused import
* Apply suggestions from code review
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
* Add missing natspec
* Add natspec to tests
---------
Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
* fix(scripts): check interfaces and libraries in testContractExistsInFile (#18370)
- update testContractExistsInFile() to match interfaces and libraries in addition to contracts
- add test cases for interface and library validation in TestTestContractExistsInFile
* op-deployer: activate jovian at genesis by default (#18342) (#18348)
* op-deployer: activate jovian at genesis by default (#18342)
* op-deployer: activate jovian at genesis by default
* fix tests for jovian activation
* use inclusive instead of exclusive arg
* op-acceptance-tests: only run Ecotone fees test against compatible networks (#18225)
* feat: add support for blockscout in VerifyOPCM (#18373)
* feat: add support for blockscout in VerifyOPCM
This commit adds support for blockscout in VerifyOPCM and defaults
to blockscout. Etherscan verification can still be used but
blockscout is simpler and more reliable on all networks.
* fix: formatting
* feat: safer safes audit (#18300)
* Use vm.prank(address,bool) for delegateCall, remove DelegateCaller contract (#18331)
* Use vm.prank(address,bool) for delegateCall, remove DelegateCaller contract
Remove imports of DelegateCaller
fmt
fix: by explicitly using delegatcall
was expecting foundry to override the CALL to a delegatcall for some
reason.
remove unused returndata vars
fix updatePrestate call testing
Fixes to ForkLive
Self review clean up
fix: handle empty EOA code in delegate call tests
Adds a prankDelegateCall() helper function to eliminate repetitive code pattern for handling Foundry's requirement that addresses have at least one byte of code to prank delegatecalls. This helper combines vm.etch() and vm.prank(_, true) into a single reusable function.
Create prankDelegateCall function
Restore DelegateCaller contract
Prevents merge conflicts with other inflight work
Clean up comments on prankDelegateCall
Delete DelegateCaller contract
* Fix outdated comment and etch restore
* fix unused imports
* Fix upgradeSuperchain call
* op-devstack: add WithArchive matcher (#18227)
and use it in the pectra acceptance tests.
* feat: have OPCMv2 revert if user tries to provide address(0) as SystemConfig for upgrade (#18376)
* fix: semver updates
* fix: semver lock
* fix: semver lock again
* op-acceptance: Add acceptance tests for withdrawals using cannon and cannon_kona (#18374)
* op-acceptance: Add acceptance tests for withdrawals using cannon and cannon_kona game types
* op-acceptance: Add game types through OPCM instead of separate op-deployer script
* op-acceptance: Remove unused method
* ci: add GitHub Actions workflow to build and attest container images (#18397)
- Add bake.yaml workflow using factory reusable multi-arch workflow
- Build all 16 OP Stack images (op-node, op-batcher, op-deployer, op-faucet, op-program, op-proposer, op-challenger, op-dispute-mon, op-conductor, da-server, op-supervisor, op-supernode, op-test-sequencer, cannon, op-dripper, op-interop-mon)
- Native ARM builds on ubuntu-24.04-arm for faster compilation
- Multi-arch manifest creation with SLSA Build Level 3 attestations
- Add compute-git-versions.sh script to replicate CircleCI GIT_VERSION logic
- Read KONA_VERSION from kona/version.json (single source of truth)
- Add Makefile target for compute-git-versions
- GitHub Actions cache support for faster builds
- BuildKit provenance (mode=max) + GitHub attestations for rich metadata
Signed-off-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
* test(contracts): improve DevFeatures test coverage with fuzz tests (#18396)
* refactor(test): rename test functions to use _succeeds suffix and add docs
- Rename all test functions from _works to _succeeds suffix
- Simplify test names by removing redundant 'check' and 'Against' words
- Add @notice documentation for each test function
* test(contracts): add fuzz tests for isDevFeatureEnabled function
- Add testFuzz_isDevFeatureEnabled_featureMatchesSelf_succeeds
- Add testFuzz_isDevFeatureEnabled_emptyFeatureAlwaysFalse_succeeds
- Add testFuzz_isDevFeatureEnabled_featureInSuperset_succeeds
- Add testFuzz_isDevFeatureEnabled_featureNotInDisjointBitmap_succeeds
---------
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
* op-challenger: Update list-games sub command to support optimistic zk games (#18393)
* op-challenger: Update list-games sub command to support optimistic zk games.
Starts to build out the OptimisticZK contract bindings and make challenger not require everything to look like a FaultDisputeGame.
* Fix variable name
* contracts: Replace mock contracts with vm.mock functions (#18388)
* Replace Reverter contract with vm.mockCallRevert()
* Replace Call Recorder with vm.expectCall()
* fix imports
* Fix selector data on recipient
* Rename Callers to GasBurner
It's the only contract left in the file now.
* ci: split bake workflow in protected/unprotected flows (#18443)
* ci: split bake workflow in protected/unprotected
* ci: address review feedback
Signed-off-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
---------
Signed-off-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
* chore(op-acceptance-tests): flake-shake; slack notifications for failures only (#18439)
* feat: add new check for strict pragma (#18390)
Adds a new check in the contracts package that confirms that all
source contracts are using a strict pragma instead of a dynamic
one.
* Add Openchain import on CI (#18447)
* start
* add upload to ci
* fix: update CI
* feat: rm update-selectors from pre-pr
* fix: rm checkout from workspace
* Add flashblocks and matrix testing support to sysgo (#18318)
* Fix CI (#18450)
* start
* add upload to ci
* fix: update CI
* feat: rm update-selectors from pre-pr
* fix: rm checkout from workspace
* fix: checkout
* fix: contract dependencies
* op-supernode: Superroot API Activity (#18180)
* op-supernode: Superroot API Activity
* Response Object Cleanup
* Update return struct for full Optimistic Outputs ; In-Proc RPC
* Use eth.NotFound Errors
* op-node: Light CL: Disabling Derivation (#18290)
* op-node: Logic for Disabling Derivation
* op-devstack: Support UnsafeOnly preset and twoVerifiers System
* op-acceptance-tests: UnsafeOnly Tests for Seq and Ver
* Do not check second verifier safe head because of EL Sync
* op-node: Fix EngineController Reset logic for sequencer init
* doc string fix
* Defensive protection for avoiding FCU to genesis
* Modularize ext sync tester config
* op-acceptance-tests: Unsafe Only with Ext Network
* Also check unsafe head advances after initial EL Sync is done
* check unsafe gap is closed
* remove temp
* Allow alt sync when unsafeOnly
* check seq restart with API
* better init EL syncing log msg
* fix comments and add warning
* Check isSequencer for unsafeOnly initial Reset at SyncDeriver
* remove non initialized check during syncDeriver step
* Refactor for readability
* feat: add OPCMv2 tests for existing behaviors (#18389)
* feat: add OPCMv2 tests for existing behaviors
* feat: more tests
* fix: lint errors
* fix: test naming
* fix: improve some tests wrt pr comments
* fix: correct …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While discussing metrics, @K-Ho raised that batch submitter should not be fixing monotonicity errors (which should now be fully handled by geth). We want to be notified if it is, because that means there is a monotonicity violation and we need to debug geth. This PR logs an error when we fix monotonicity errors in batch submitter, which will then notify us through Sentry.
Additional context
log.errors are piped to sentry which notifies us.