Skip to content

sdk: fix withdrawal bug#5459

Merged
OptimismBot merged 13 commits intodevelopfrom
sc/prove-fix-test
Apr 19, 2023
Merged

sdk: fix withdrawal bug#5459
OptimismBot merged 13 commits intodevelopfrom
sc/prove-fix-test

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Apr 14, 2023 •
edited by tynes
Loading

Description

Fixes a bug in the sdk that allows it to work with migrated withdrawals. This fix is necessary to ensure that withdrawals initiated with the legacy system can be finalized on bedrock. Includes test coverage of computing the storage slot in the message passer as well as a test using anvil to actually finalize a withdrawal.

Closes CLI-3836

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e4c17c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 14, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 2e4c17c
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/644054c6de98d2000920e4d6

@mergify mergify bot added the sdk label Apr 14, 2023
@mergify mergify bot requested a review from roninjin10 April 14, 2023 20:30
@tynes tynes mentioned this pull request Apr 17, 2023
Merged
@tynes tynes force-pushed the sc/prove-fix-test branch from 6a36681 to 80c5f6d Compare April 18, 2023 16:53
@tynes tynes force-pushed the sc/prove-fix-test branch from 8d864e5 to 348cca8 Compare April 18, 2023 20:25
@tynes tynes force-pushed the sc/prove-fix-test branch from 348cca8 to 6c87ec9 Compare April 18, 2023 20:28
@tynes tynes changed the title Sc/prove fix test sdk: fix withdrawal bug Apr 18, 2023
@tynes tynes marked this pull request as ready for review April 18, 2023 20:30
@tynes tynes requested review from a team as code owners April 18, 2023 20:30
@tynes tynes requested a review from trianglesphere April 18, 2023 20:30
trianglesphere
trianglesphere reviewed Apr 18, 2023
View reviewed changes
roninjin10
roninjin10 suggested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update some of the CI I added here before we land it

@tynes
Copy link
Contributor

tynes commented Apr 19, 2023

Looks like you force pushed away my commits

@roninjin10
Copy link
Contributor

roninjin10 commented Apr 19, 2023

Ooops

@roninjin10
Copy link
Contributor

roninjin10 commented Apr 19, 2023

fixing

roninjin10
roninjin10 reviewed Apr 19, 2023
View reviewed changes
@roninjin10
Copy link
Contributor

roninjin10 commented Apr 19, 2023

Put a do-not-merge on it since it should get an approval from someone other than me since I wrote some of this code

roninjin10
roninjin10 reviewed Apr 19, 2023
View reviewed changes
roninjin10
roninjin10 reviewed Apr 19, 2023
View reviewed changes
@tynes tynes requested review from clabby and refcell April 19, 2023 16:51
tynes
tynes reviewed Apr 19, 2023
View reviewed changes
trianglesphere
trianglesphere reviewed Apr 19, 2023
View reviewed changes
roninjin10
roninjin10 reviewed Apr 19, 2023
View reviewed changes
roninjin10
roninjin10 reviewed Apr 19, 2023
View reviewed changes
@roninjin10 @trianglesphere
comments: formatting and zod dev dep
f3f949b 
Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
trianglesphere
trianglesphere approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI config LGTM

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 19, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 2fa4d36 into develop Apr 19, 2023
@OptimismBot OptimismBot deleted the sc/prove-fix-test branch April 19, 2023 21:09
@mergify mergify bot removed the on-merge-train label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@clabby clabby Awaiting requested review from clabby

@refcell refcell Awaiting requested review from refcell

+2 more reviewers

@roninjin10 roninjin10 roninjin10 approved these changes

@trianglesphere trianglesphere trianglesphere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smartcontracts @tynes @roninjin10 @trianglesphere @OptimismBot