Skip to content

op-program: Modify L2 oracle to not return error#5419

Merged
OptimismBot merged 2 commits intodevelopfrom
aj/fpp-l2-no-error
Apr 11, 2023
Merged

op-program: Modify L2 oracle to not return error#5419
OptimismBot merged 2 commits intodevelopfrom
aj/fpp-l2-no-error

Conversation

@ajsutton
Copy link
Contributor

Description

Modify the L2 oracle interface so that it panics if the requested data isn't available and no errors are ever returned. This fits the on-chain execution model better.

@ajsutton ajsutton requested a review from a team as a code owner April 11, 2023 22:01
@ajsutton ajsutton requested a review from mslipper April 11, 2023 22:01
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

⚠️ No Changeset found

Latest commit: c511d9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit c511d9f
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6435e09101d69f0008feb43d

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 5015417 into develop Apr 11, 2023
@OptimismBot OptimismBot deleted the aj/fpp-l2-no-error branch April 11, 2023 22:50
@mergify mergify bot removed the on-merge-train label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants