op-batcher: Shutdown pprof and metrics after main loop returns

[sebastianst]

Description

The batcher's main function currently stops pprof and metrics immediately when receiving any stop signal, like SIGINT. This PR swaps the order and let's it first wait for the main loop to return and only then cancel pprof and metrics.

The error from stopping the http server is now also logged.

TODOs

• Author or reviewer has added an entry to the current release notes draft, if appropriate. [not appropriate]

[changeset-bot]

⚠️ No Changeset found

Latest commit: c301829

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	c301829
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/642d9a9eaa91ba0007cdbd4b

[trianglesphere]

Seems like it should work.

[codecov]

Codecov Report

Merging #5345 (5712cee) into develop (21f3afb) will decrease coverage by 3.56%.
The diff coverage is 0.00%.

❗ Current head 5712cee differs from pull request most recent head c301829. Consider uploading reports for the commit c301829 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5345      +/-   ##
===========================================
- Coverage    39.09%   35.54%   -3.56%     
===========================================
  Files          393      238     -155     
  Lines        26144    21638    -4506     
  Branches       838        0     -838     
===========================================
- Hits         10222     7691    -2531     
+ Misses       15141    13204    -1937     
+ Partials       781      743      -38     

Flag	Coverage Δ
bedrock-go-tests	35.54% <0.00%> (+0.03%)	⬆️
common-ts-tests	?
contracts-bedrock-tests	?
contracts-tests	?
core-utils-tests	?
dtl-tests	?
fault-detector-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
op-batcher/batcher/batch_submitter.go	0.00% <0.00%> (ø)

... and 158 files with indirect coverage changes

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.