Skip to content

txmgr: add more tx metrics#5331

Merged
OptimismBot merged 2 commits intoethereum-optimism:developfrom
shrimalmadhur:madhur/tx-metrics
Apr 4, 2023
Merged

txmgr: add more tx metrics#5331
OptimismBot merged 2 commits intoethereum-optimism:developfrom
shrimalmadhur:madhur/tx-metrics

Conversation

@shrimalmadhur
Copy link
Contributor

  • Add metrics to track confirmed tx latency
  • Add metrics to track how many time tx gas price had to be bumped beofre it got included

Description

A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Invariants

For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 0c3b866

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 0c3b866
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642ca90ec6f88a0008ec0de6

@shrimalmadhur shrimalmadhur force-pushed the madhur/tx-metrics branch 2 times, most recently from 0f990df to 80188b7 Compare April 3, 2023 19:37
@shrimalmadhur shrimalmadhur marked this pull request as ready for review April 4, 2023 20:58
@shrimalmadhur shrimalmadhur requested a review from a team as a code owner April 4, 2023 20:58
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #5331 (0c3b866) into develop (44eec0d) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5331      +/-   ##
===========================================
- Coverage    39.85%   39.83%   -0.03%     
===========================================
  Files          391      391              
  Lines        25634    25657      +23     
  Branches       838      838              
===========================================
+ Hits         10216    10220       +4     
- Misses       14639    14657      +18     
- Partials       779      780       +1     
Flag Coverage Δ
bedrock-go-tests 36.31% <33.33%> (-0.03%) ⬇️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 51.32% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-service/txmgr/metrics/tx_metrics.go 0.00% <0.00%> (ø)
op-service/txmgr/metrics/noop.go 100.00% <100.00%> (ø)
op-service/txmgr/txmgr.go 76.63% <100.00%> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

@OptimismBot OptimismBot merged commit b424c7c into ethereum-optimism:develop Apr 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants