Skip to content

txmgr: Add more metrics#5322

Merged
OptimismBot merged 2 commits intodevelopfrom
jg/extended_metrics
Apr 5, 2023
Merged

txmgr: Add more metrics#5322
OptimismBot merged 2 commits intodevelopfrom
jg/extended_metrics

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Mar 31, 2023

Description

Adds more metrics to the transaction manager. Also simplifies metric recording a little bit.

TODOs

@trianglesphere trianglesphere requested a review from a team as a code owner March 31, 2023 20:07
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

⚠️ No Changeset found

Latest commit: 3daf6e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 3daf6e1
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642dde17b7081200084b6cdc

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

⚠️ The sha of the head commit of this PR conflicts with #5307. Mergify cannot evaluate rules on this PR. ⚠️

@trianglesphere trianglesphere marked this pull request as draft March 31, 2023 20:07
@trianglesphere trianglesphere marked this pull request as ready for review March 31, 2023 20:20
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

⚠️ The sha of the head commit of this PR conflicts with #5307. Mergify cannot evaluate rules on this PR. ⚠️

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

⚠️ The sha of the head commit of this PR conflicts with #5307. Mergify cannot evaluate rules on this PR. ⚠️

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #5322 (3daf6e1) into develop (cb8fbc4) will decrease coverage by 3.64%.
The diff coverage is 17.74%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5322      +/-   ##
===========================================
- Coverage    39.09%   35.45%   -3.64%     
===========================================
  Files          393      238     -155     
  Lines        26147    21697    -4450     
  Branches       838        0     -838     
===========================================
- Hits         10222     7693    -2529     
+ Misses       15144    13259    -1885     
+ Partials       781      745      -36     
Flag Coverage Δ
bedrock-go-tests 35.45% <17.74%> (-0.05%) ⬇️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-service/metrics/event.go 0.00% <0.00%> (ø)
op-service/txmgr/metrics/tx_metrics.go 0.00% <0.00%> (ø)
op-service/txmgr/txmgr.go 74.75% <41.17%> (-1.88%) ⬇️
op-service/txmgr/metrics/noop.go 100.00% <100.00%> (ø)

... and 155 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Apr 4, 2023

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Apr 4, 2023
@mergify mergify bot removed the conflict label Apr 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 18747f1 into develop Apr 5, 2023
@OptimismBot OptimismBot deleted the jg/extended_metrics branch April 5, 2023 21:05
@mergify mergify bot removed the on-merge-train label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants