Closed
Conversation
Add a getter to the `hre.deployConfig` object that gives access to alternative network's deploy configs. This is useful because multiple networks can be linked and share config. In particular when L2 networks are used with L1 networks, the entire deploy config has be be shared with both networks so it results in a copy paste.
🦋 Changeset detectedLatest commit: a82d337 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for opstack-docs canceled.
|
Contributor
Author
|
This PR would let us get rid of the copy/paste of the entire deploy config in #5314 |
Contributor
|
Curious how you went about testing this? I tried with |
Contributor
Author
Did you build the package? I didn't have any issues running it after building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a getter to the
hre.deployConfigobjectthat gives access to alternative network's deploy
configs. This is useful because multiple networks
can be linked and share config. In particular when L2 networks are used with L1 networks, the entire
deploy config has be be shared with both networks
so it results in a copy paste.