Skip to content

🤼 DisputeGame interfaces#5304

Merged
clabby merged 3 commits intospecs/dispute-game-interfacefrom
clabby/specs/dispute-game-interface
Apr 4, 2023
Merged

🤼 DisputeGame interfaces#5304
clabby merged 3 commits intospecs/dispute-game-interfacefrom
clabby/specs/dispute-game-interface

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Mar 30, 2023

Overview

Expands on the dispute game interface started in #5264 by @tynes.

Metadata

TODOs

@clabby clabby requested review from a team as code owners March 30, 2023 21:04
@clabby clabby requested review from mslipper and smartcontracts and removed request for a team March 30, 2023 21:04
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

⚠️ No Changeset found

Latest commit: 0f4acf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clabby clabby requested review from refcell and tynes March 30, 2023 21:08
🧹
@clabby clabby force-pushed the clabby/specs/dispute-game-interface branch from 910fa06 to ee69016 Compare March 30, 2023 21:49
@clabby clabby requested a review from tynes March 31, 2023 01:07
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #5304 (0f4acf1) into specs/dispute-game-interface (2d66c22) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           specs/dispute-game-interface    #5304      +/-   ##
================================================================
- Coverage                         37.98%   37.96%   -0.02%     
================================================================
  Files                               211      211              
  Lines                             17832    17832              
================================================================
- Hits                               6773     6770       -3     
- Misses                            10391    10393       +2     
- Partials                            668      669       +1     
Flag Coverage Δ
bedrock-go-tests 37.96% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@clabby clabby merged commit 600a2a7 into specs/dispute-game-interface Apr 4, 2023
@clabby clabby deleted the clabby/specs/dispute-game-interface branch April 4, 2023 16:39
clabby added a commit that referenced this pull request Apr 5, 2023
* 🤼 DisputeGame interfaces

* 🧹

🧹

* Andreas' nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants