op-service/txmgr : add tx manager metrics#5295
op-service/txmgr : add tx manager metrics#5295mergify[bot] merged 2 commits intoethereum-optimism:developfrom
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
trianglesphere
left a comment
There was a problem hiding this comment.
Will conflict with #5286, but nothing major.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5295 +/- ##
===========================================
- Coverage 39.88% 39.87% -0.02%
===========================================
Files 382 384 +2
Lines 24390 24406 +16
Branches 838 838
===========================================
+ Hits 9729 9732 +3
- Misses 13930 13943 +13
Partials 731 731
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9ebe636 to
a890e8b
Compare
sebastianst
left a comment
There was a problem hiding this comment.
Looks good! Just a minor comment about embedding the NoopTxMetrics
13c459f to
694d8dd
Compare
|
Hey @shrimalmadhur! This PR has merge conflicts. Please fix them before continuing review. |
add L1 fee
694d8dd to
78d9c5e
Compare
requested changes were implemented
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1/n PR for op-service/txmgr: Transaction Manager Metrics #5291
Adding metrics for transaction manager
Embed and initialize from
op-proposerandop-batcherAdd L1 Gas fee metrics
Test L1 gas metrics using
devnetA clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Invariants
For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.
Additional context
Add any other context about the problem you're solving.
Metadata
TODOs