Skip to content

op-service/txmgr : add tx manager metrics#5295

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
shrimalmadhur:madhur/txmgr-metrics
Mar 31, 2023
Merged

op-service/txmgr : add tx manager metrics#5295
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
shrimalmadhur:madhur/txmgr-metrics

Conversation

@shrimalmadhur
Copy link
Contributor

@shrimalmadhur shrimalmadhur commented Mar 29, 2023

 HELP op_proposer_default_txmgr_tx_fee L1 gas fee for a transaction in GWEI
# TYPE op_proposer_default_txmgr_tx_fee gauge
op_proposer_default_txmgr_tx_fee 89488

A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Invariants

For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

TODOs

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: 6b28769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 29, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 6b28769
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642734f538fe0f0008a07135

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will conflict with #5286, but nothing major.

@shrimalmadhur shrimalmadhur changed the title op-service: add tx manager metrics op-service/txmgr : add tx manager metrics Mar 30, 2023
@shrimalmadhur shrimalmadhur marked this pull request as ready for review March 31, 2023 17:19
@shrimalmadhur shrimalmadhur requested a review from a team as a code owner March 31, 2023 17:19
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #5295 (6b28769) into develop (fcff9ae) will decrease coverage by 0.02%.
The diff coverage is 18.18%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5295      +/-   ##
===========================================
- Coverage    39.88%   39.87%   -0.02%     
===========================================
  Files          382      384       +2     
  Lines        24390    24406      +16     
  Branches       838      838              
===========================================
+ Hits          9729     9732       +3     
- Misses       13930    13943      +13     
  Partials       731      731              
Flag Coverage Δ
bedrock-go-tests 36.14% <18.18%> (-0.02%) ⬇️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 51.32% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/batcher/driver.go 0.00% <0.00%> (ø)
op-batcher/metrics/metrics.go 0.00% <0.00%> (ø)
op-batcher/metrics/noop.go 46.15% <ø> (ø)
op-proposer/metrics/metrics.go 0.00% <0.00%> (ø)
op-proposer/metrics/noop.go 0.00% <ø> (ø)
op-proposer/proposer/l2_output_submitter.go 2.77% <0.00%> (ø)
op-service/txmgr/metrics/tx_metrics.go 0.00% <0.00%> (ø)
op-service/txmgr/metrics/noop.go 100.00% <100.00%> (ø)
op-service/txmgr/txmgr.go 79.09% <100.00%> (+0.14%) ⬆️

@shrimalmadhur shrimalmadhur force-pushed the madhur/txmgr-metrics branch 2 times, most recently from 9ebe636 to a890e8b Compare March 31, 2023 17:34
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor comment about embedding the NoopTxMetrics

@shrimalmadhur shrimalmadhur force-pushed the madhur/txmgr-metrics branch 2 times, most recently from 13c459f to 694d8dd Compare March 31, 2023 18:18
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

Hey @shrimalmadhur! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Mar 31, 2023
@mergify mergify bot removed the conflict label Mar 31, 2023
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trianglesphere trianglesphere dismissed sebastianst’s stale review March 31, 2023 19:23

requested changes were implemented

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit d236185 into ethereum-optimism:develop Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants