Skip to content

contracts-bedrock: deploy implementations to goerli#5280

Merged
tynes merged 2 commits intodevelopfrom
feat/goerli-deploy
Mar 30, 2023
Merged

contracts-bedrock: deploy implementations to goerli#5280
tynes merged 2 commits intodevelopfrom
feat/goerli-deploy

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Mar 28, 2023

Description

Includes all of the audit fixes. The upgrades via the ProxyAdmin must all happen in a single atomic transaction to ensure there are no errors due to inter-contract API changes.

This does not include the changes in #5279. The SystemConfig contract will need to be deployed again.

edit: now includes the latest SystemConfig changes

@tynes tynes requested a review from a team as a code owner March 28, 2023 21:32
@tynes tynes requested a review from maurelian March 28, 2023 21:32
@changeset-bot
Copy link

changeset-bot bot commented Mar 28, 2023

⚠️ No Changeset found

Latest commit: b7fbec9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit b7fbec9
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6423f269d441f10008bfdcce
😎 Deploy Preview https://deploy-preview-5280--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tynes added 2 commits March 29, 2023 01:01
Includes all of the audit fixes. The upgrades via the `ProxyAdmin`
must all happen in a single atomic transaction to ensure there
are no errors due to inter-contract API changes.

This does not include the changes in
#5279.
The `SystemConfig` contract will need to be deployed again.
@tynes tynes force-pushed the feat/goerli-deploy branch from 4c71eed to b7fbec9 Compare March 29, 2023 08:10
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

This PR has been added to the merge queue, and will be merged soon.

@tynes tynes merged commit cb02888 into develop Mar 30, 2023
@tynes tynes deleted the feat/goerli-deploy branch March 30, 2023 06:57
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants