Use OptimismPortal.FINALIZATION_PERIOD_SECONDS if L2OutputOracle.version is '1.0.0'.#5277
Use OptimismPortal.FINALIZATION_PERIOD_SECONDS if L2OutputOracle.version is '1.0.0'.#5277mergify[bot] merged 7 commits intodevelopfrom
Conversation
Develop -> Master
|
✅ Deploy Preview for opstack-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
@eth-optimism/sdk starting at 2.0.0 is assuming the
FINALIZATION_PERIOD_SECONDis moved to L2OutputOracle, which is not the case for L2OutputOracle.version === '1.0.0'.Version 1.0.0 of the L2OutputOracle is still deployed at Goerli, and all SDK consumers depending on the
FINALIZATION_PERIOD_SECONDare broken right now (e.g. the fault-detector). This PR makes the sdk work with both 1.0.0 and the latest version of smart contracts.Tests
No tests added. Manually ran
yarn startin fault-detector to confirm this fixed the breakage.Happy add a test if necessary.
Invariants
N/A since this PR does not change critical path.