op-proposer: add L1 fee metrics#5268
op-proposer: add L1 fee metrics#5268shrimalmadhur wants to merge 1 commit intoethereum-optimism:developfrom
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
| m.RecordL2Ref(BlockProposed, l2ref) | ||
| } | ||
|
|
||
| func (m *Metrics) RecordL1GasFee(receipt *types.Receipt) { |
There was a problem hiding this comment.
@sebastianst I also want to add this metrics to batcher so I am wondering if I should add that is in op-service metrics.go file (ref_metrics.go) and re-use it.
Or ref_metrics is only for block ref data and I need to explicitly add this metrics on both places?
There was a problem hiding this comment.
Gas fee tracking shouldn't be part of the RefMetrics, that's purely for reference data.
We just did a refactor in the op-batcher and op-proposer to move more transaction handling into the op-service/txmgr. So this metric (together with a few other metrics) should probably be added to the txmgr so that it's available to both, the batcher and proposer. It is on our radar to add metrics there. We can sync on that :)
There was a problem hiding this comment.
oh nice. just saw the refactored code on txmgr. I am happy to help with this. Let me know if you have some guidance for me about what ways you are expecting. I can wait till both op-batcher and op-proposer go via the new txmgr codebase and then add metrics. Let me know :)
There was a problem hiding this comment.
That sounds great, I'll write up an issue for the txmgr metrics and let you know.
There was a problem hiding this comment.
@shrimalmadhur here's the issue #5291 hope it has enough context & info. feel free to ask questions in that issue.
There was a problem hiding this comment.
Hey @shrimalmadhur I've got one more set of large change to the internals of the txmgr here (#5286, still WIP), but is shouldn't change the constructor/initialization flow.
There was a problem hiding this comment.
Thanks @sebastianst ! I will start working on it. I will close this PR and start a different one just to make things cleaner.
add noop metrics fix the method
shrimalmadhur
force-pushed
the
madhur/emit-gas-fee
branch
from
b61206d to
46bf607
Compare
|
Closing this PR to start working on #5291 in separate PR. |
3 participants
Description
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Invariants
For changes to critical code paths, please list and describe the invariants or key security properties of your new or changed code.
Additional context
Add any other context about the problem you're solving.
Metadata
TODOs