Skip to content

op-node: reset back to optimal receipt fetching methods#5231

Merged
mergify[bot] merged 2 commits intodevelopfrom
available-rpc-methods-fix
Mar 23, 2023
Merged

op-node: reset back to optimal receipt fetching methods#5231
mergify[bot] merged 2 commits intodevelopfrom
available-rpc-methods-fix

Conversation

@protolambda
Copy link
Contributor

Description

Reset it back after a while to not fallback permanently to sub-optimal RPC methods for receipt fetching.

Tests

Updated test to see if method preference can be sticky and reset back if configured to do so.

TODOs

Fix CLI-3697

@protolambda protolambda requested a review from a team as a code owner March 22, 2023 19:12
@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

⚠️ No Changeset found

Latest commit: 84fda21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 84fda21
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/641c97757a6fc500087257ae

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #5231 (099fadf) into develop (d6441e6) will decrease coverage by 3.81%.
The diff coverage is 91.66%.

❗ Current head 099fadf differs from pull request most recent head 84fda21. Consider uploading reports for the commit 84fda21 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5231      +/-   ##
===========================================
- Coverage    40.07%   36.26%   -3.81%     
===========================================
  Files          372      217     -155     
  Lines        23605    18975    -4630     
  Branches       832        0     -832     
===========================================
- Hits          9459     6882    -2577     
+ Misses       13438    11423    -2015     
+ Partials       708      670      -38     
Flag Coverage Δ
bedrock-go-tests 36.26% <91.66%> (+0.03%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/sources/l2_client.go 0.00% <0.00%> (ø)
op-node/sources/eth_client.go 37.91% <100.00%> (-0.66%) ⬇️
op-node/sources/l1_client.go 42.18% <100.00%> (+0.91%) ⬆️

... and 176 files with indirect coverage changes

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback seems to work. Do we know if we've hit this before?
Also, on the testing side, how does the test verify that we undo the fallback?

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit f7d0e1a into develop Mar 23, 2023
@mergify mergify bot deleted the available-rpc-methods-fix branch March 23, 2023 18:44
@mergify mergify bot removed the on-merge-train label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants