fix(op-node): Peer Scoring Metrics

[refcell]

Description

Fixes CLI-3646

Adds a quick-fix to the peer scoring p2p flags in op-node and adds back the peer_id so we can track peer scores in testing environments.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 787db60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs ready!

Name	Link
🔨 Latest commit	787db60
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/641b6ebd21b8c20008664eaa
😎 Deploy Preview	https://deploy-preview-5204--opstack-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #5204 (787db60) into develop (8dd0248) will decrease coverage by 3.81%.
The diff coverage is 50.58%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5204      +/-   ##
===========================================
- Coverage    40.00%   36.19%   -3.81%     
===========================================
  Files          371      217     -154     
  Lines        23512    19082    -4430     
  Branches       832        0     -832     
===========================================
- Hits          9405     6907    -2498     
+ Misses       13402    11503    -1899     
+ Partials       705      672      -33     

Flag	Coverage Δ
bedrock-go-tests	36.19% <50.58%> (+0.06%)	⬆️
common-ts-tests	?
contracts-bedrock-tests	?
contracts-tests	?
core-utils-tests	?
dtl-tests	?
fault-detector-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
op-node/flags/p2p_flags.go	100.00% <ø> (ø)
op-node/metrics/metrics.go	1.31% <0.00%> (-0.02%)	⬇️
op-node/p2p/cli/load_config.go	0.00% <0.00%> (ø)
op-node/p2p/gossip.go	38.66% <ø> (ø)
op-node/p2p/mocks/ConnectionGater.go	5.06% <0.00%> (-0.10%)	⬇️
op-node/p2p/mocks/PeerGater.go	25.00% <ø> (ø)
op-node/p2p/mocks/Peerstore.go	0.00% <ø> (ø)
op-node/p2p/prepared.go	0.00% <0.00%> (ø)
op-node/p2p/peer_scorer.go	87.50% <84.44%> (-12.50%)	⬇️
op-node/p2p/config.go	31.48% <100.00%> (+2.63%)	⬆️
... and 2 more

... and 155 files with indirect coverage changes

[ajsutton]

The Bucketable interface is a really nice little abstraction. Good thinking.

[sebastianst]

please make sure to clean up old implementation artifacts

[trianglesphere]

I really like the score bands & stream_count metrics, but I'm a little confused on how the BandScorer is being used.

[ajsutton]

Looks ok to me. Left a couple of suggestions but will defer to Seb and Josh for the bigger picture stuff.

[ajsutton]

hmm, running this locally with --p2p.scoring.peers=light --p2p.ban.peers I always get:

op_node_default_p2p_peer_scores{band=""} 1

and my very malicious peer that's spamming invalid gossip isn't being disconnected.
Even when I specify --p2p.score.bands="-40:graylist;-20:restricted;0:nopx;20:friend;" as well I still don't get any named bands in metrics.

[sebastianst]

Looks good to me now, excited to see this in action soon 🤩 Just some minor suggestions for further simplification.

[trianglesphere]

ops changes lgtm. Only one q about the prepared p2p stuff

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.