Skip to content

feat(op-service): Move Tx Creation to the txmgr#5191

Merged
mergify[bot] merged 22 commits intodevelopfrom
refcell/feat/txcreation
Mar 23, 2023
Merged

feat(op-service): Move Tx Creation to the txmgr#5191
mergify[bot] merged 22 commits intodevelopfrom
refcell/feat/txcreation

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Mar 17, 2023

Description

Fixes CLI-3548

Moves transaction creation to the txmgr in the op-service. Rational is that there are two primary places where txs are sent - the op-proposer and op-batcher. In each, we currently have to role our own transaction construction since the op-service doesn't support creation. This is a generalized solution to tx creation in the txmgr.

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

⚠️ No Changeset found

Latest commit: be704d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refcell refcell self-assigned this Mar 17, 2023
@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for opstack-docs ready!

Name Link
🔨 Latest commit be704d5
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/641c9e25b89df10008255322
😎 Deploy Preview https://deploy-preview-5191--opstack-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

Hey @refcell! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Mar 20, 2023
@mergify mergify bot removed the conflict label Mar 20, 2023
@refcell refcell marked this pull request as ready for review March 21, 2023 13:12
@refcell refcell requested a review from a team as a code owner March 21, 2023 13:12
@refcell refcell requested a review from mslipper March 21, 2023 13:12
@mslipper mslipper requested a review from trianglesphere March 21, 2023 15:42
@refcell refcell requested a review from a team as a code owner March 21, 2023 19:29
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file op-batcher/batcher/txmgr.go should also be removed.

@trianglesphere trianglesphere requested review from sebastianst and removed request for mslipper March 22, 2023 18:36
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor comments.

Would also like to see CraftTx be done inside Send and removed from the interface, but not sure how much this would blow up the pr.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #5191 (eb591ae) into develop (84fda21) will increase coverage by 0.25%.
The diff coverage is 51.25%.

❗ Current head eb591ae differs from pull request most recent head be704d5. Consider uploading reports for the commit be704d5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5191      +/-   ##
===========================================
+ Coverage    36.28%   36.53%   +0.25%     
===========================================
  Files          218      217       -1     
  Lines        19127    19024     -103     
===========================================
+ Hits          6940     6951      +11     
+ Misses       11514    11381     -133     
- Partials       673      692      +19     
Flag Coverage Δ
bedrock-go-tests 36.53% <51.25%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-batcher/batcher/config.go 0.00% <0.00%> (ø)
op-batcher/flags/flags.go 100.00% <ø> (ø)
op-batcher/batcher/driver.go 5.34% <46.66%> (+5.34%) ⬆️
op-service/txmgr/mocks/TxManager.go 47.82% <47.82%> (ø)
op-service/txmgr/txmgr.go 81.59% <67.64%> (-4.32%) ⬇️

... and 25 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 3152615 into develop Mar 23, 2023
@mergify mergify bot deleted the refcell/feat/txcreation branch March 23, 2023 19:03
@mergify mergify bot removed the on-merge-train label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants