feat(op-service): Move Tx Creation to the txmgr#5191
Conversation
|
✅ Deploy Preview for opstack-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hey @refcell! This PR has merge conflicts. Please fix them before continuing review. |
trianglesphere
left a comment
There was a problem hiding this comment.
The file op-batcher/batcher/txmgr.go should also be removed.
sebastianst
left a comment
There was a problem hiding this comment.
Looking good, just some minor comments.
Would also like to see CraftTx be done inside Send and removed from the interface, but not sure how much this would blow up the pr.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5191 +/- ##
===========================================
+ Coverage 36.28% 36.53% +0.25%
===========================================
Files 218 217 -1
Lines 19127 19024 -103
===========================================
+ Hits 6940 6951 +11
+ Misses 11514 11381 -133
- Partials 673 692 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Fixes CLI-3548
Moves transaction creation to the
txmgrin theop-service. Rational is that there are two primary places where txs are sent - theop-proposerandop-batcher. In each, we currently have to role our own transaction construction since theop-servicedoesn't support creation. This is a generalized solution to tx creation in thetxmgr.