Skip to content

Revert single step OVM_ETH migration#5147

Merged
mslipper merged 2 commits intodevelopfrom
bugfix/revert-single-step
Mar 15, 2023
Merged

Revert single step OVM_ETH migration#5147
mslipper merged 2 commits intodevelopfrom
bugfix/revert-single-step

Conversation

@mslipper
Copy link
Contributor

@mslipper mslipper commented Mar 15, 2023

The single-step OVM_ETH check followed by migration seemed to introduce errors into the migration. Specifically, a recent migration test yielded the following error:

Mar 15 00:48:22 migration-workstation migrate-l2-slipper-test.sh[112103]: ERROR[03-15|00:48:22.468] account has non-zero balance in state - should never happen addr=0x0000000000000000000000000000000000000000
Mar 15 00:48:22 migration-workstation migrate-l2-slipper-test.sh[112103]: CRIT [03-15|00:48:22.483] error in migration                       err="cannot migrate legacy eth: error in migration: account has non-zero balance in state - should never happen: 0x0000000000000000000000000000000000000000"

This implies that there is either a bug somewhere in the optimized code, or that there is an issue with modifying state while iterating it. This PR reverts the optimization, while retaining the corrected storage slots in check.go.

Reverts the following commits:

Revert "op-chain-ops: Fix dry run param"

This reverts commit d76a327.

Revert "Fix lint"

This reverts commit 9aa4a6c.

Revert "Use correct storage slots"

This reverts commit f05c0b9.

Revert "op-chain-ops: Improve OVM_ETH migration, remove invalid check slots"

This reverts commit 918c1d7.
@mslipper mslipper requested a review from a team as a code owner March 15, 2023 03:55
@mslipper mslipper requested a review from trianglesphere March 15, 2023 03:55
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

⚠️ No Changeset found

Latest commit: e77d6b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 15, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit e77d6b5
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6411425e7dc54e000834a591

@mslipper mslipper force-pushed the bugfix/revert-single-step branch from f59bee2 to e77d6b5 Compare March 15, 2023 03:58
@mslipper mslipper requested a review from tynes March 15, 2023 03:59
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #5147 (e77d6b5) into develop (7bdcb0f) will decrease coverage by 4.98%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5147      +/-   ##
===========================================
- Coverage    41.29%   36.31%   -4.98%     
===========================================
  Files          351      209     -142     
  Lines        21334    17242    -4092     
  Branches       776        0     -776     
===========================================
- Hits          8809     6262    -2547     
+ Misses       11854    10348    -1506     
+ Partials       671      632      -39     
Flag Coverage Δ
bedrock-go-tests 36.31% <0.00%> (-0.75%) ⬇️
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-chain-ops/ether/cli.go 0.00% <0.00%> (-100.00%) ⬇️
op-chain-ops/ether/migrate.go 0.00% <0.00%> (-69.68%) ⬇️
op-chain-ops/ether/precheck.go 0.00% <0.00%> (ø)
op-chain-ops/genesis/check.go 1.51% <ø> (ø)
op-chain-ops/genesis/db_migration.go 0.00% <0.00%> (ø)

... and 145 files with indirect coverage changes

@mslipper mslipper merged commit cc10663 into develop Mar 15, 2023
@mslipper mslipper deleted the bugfix/revert-single-step branch March 15, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants