Revert single step OVM_ETH migration#5147
Merged
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
f59bee2 to
e77d6b5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5147 +/- ##
===========================================
- Coverage 41.29% 36.31% -4.98%
===========================================
Files 351 209 -142
Lines 21334 17242 -4092
Branches 776 0 -776
===========================================
- Hits 8809 6262 -2547
+ Misses 11854 10348 -1506
+ Partials 671 632 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tynes
reviewed
Mar 15, 2023
tynes
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-step OVM_ETH check followed by migration seemed to introduce errors into the migration. Specifically, a recent migration test yielded the following error:
This implies that there is either a bug somewhere in the optimized code, or that there is an issue with modifying state while iterating it. This PR reverts the optimization, while retaining the corrected storage slots in
check.go.Reverts the following commits: