Skip to content

op-e2e: Run CI in parallel#5093

Merged
mergify[bot] merged 3 commits intodevelopfrom
jg/parallel_op_e2e
Mar 9, 2023
Merged

op-e2e: Run CI in parallel#5093
mergify[bot] merged 3 commits intodevelopfrom
jg/parallel_op_e2e

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Mar 9, 2023

Description

This gains about a 2x increase in the op-e2e test speed (16 mins -> 8 mins).
I needed to roll back a change I made to how TestMixedWithdrawalValidity was
being ran because that test did not handle the subtests being ran in parallel.

@trianglesphere trianglesphere requested review from a team as code owners March 9, 2023 02:25
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

⚠️ No Changeset found

Latest commit: 3943664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere requested review from mslipper and removed request for protolambda and zhwrd March 9, 2023 02:25
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #5093 (3943664) into develop (b5bbc74) will increase coverage by 31.58%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5093       +/-   ##
============================================
+ Coverage    40.98%   72.57%   +31.58%     
============================================
  Files          339      105      -234     
  Lines        20789     2388    -18401     
  Branches       771      411      -360     
============================================
- Hits          8520     1733     -6787     
+ Misses       11611      620    -10991     
+ Partials       658       35      -623     
Flag Coverage Δ
bedrock-go-tests ?
contracts-bedrock-tests 49.74% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/rollup/derive/system_config.go
op-service/rpc/cli.go
op-node/rollup/driver/origin_selector.go
op-chain-ops/genesis/genesis.go
packages/sdk/src/utils/assert.ts
packages/sdk/tasks/deposit-erc20.ts
op-node/rollup/derive/attributes_queue.go
packages/sdk/src/adapters/standard-bridge.ts
op-chain-ops/ether/genesis.go
op-chain-ops/crossdomain/legacy_withdrawal.go
... and 224 more

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 45f9fe4 into develop Mar 9, 2023
@mergify mergify bot deleted the jg/parallel_op_e2e branch March 9, 2023 03:27
@mergify mergify bot removed the on-merge-train label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants