contracts-bedrock: remove deployment ownable check l1xdm#5082
contracts-bedrock: remove deployment ownable check l1xdm#5082mergify[bot] merged 2 commits intodevelopfrom
Conversation
|
tynes
force-pushed
the
fix/remove-ownable-checks-l1xdm
branch
from
af91e32 to
332c1ce
Compare
The new `L1CrossDomainMessenger` is no longer ownable so we no longer need to transfer the ownership to the dictator as part of the system upgrade. The dictator does not need ownership of the old contract because it doesn't call `pause` on the `L1CrossDomainMessenger` anymore as part of the on chain upgrade. Instead, the pausable functionality is in the `OptimismPortal` which is set with a constructor arg and its pausability can be toggled using functions on the portal.
tynes
force-pushed
the
fix/remove-ownable-checks-l1xdm
branch
from
332c1ce to
2169ddc
Compare
|
Fixes CLI-3580 |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5082 +/- ##
===========================================
+ Coverage 41.01% 41.03% +0.01%
===========================================
Files 340 340
Lines 20799 20799
Branches 772 772
===========================================
+ Hits 8531 8535 +4
+ Misses 11612 11608 -4
Partials 656 656
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3 participants
Description
The new
L1CrossDomainMessengeris no longer ownable so we no longer need to transfer the ownership to the dictator as part of the system upgrade. The dictator does not need ownership of the old contract because it doesn't callpauseon theL1CrossDomainMessengeranymore as part of the on chain upgrade. Instead, the pausable functionality is in theOptimismPortalwhich is set with a constructor arg and its pausability can be toggled using functions on the portal.