Skip to content

batch_decoder: Force close channels#5075

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/batch_decoder_force_close
Mar 16, 2023
Merged

batch_decoder: Force close channels#5075
mergify[bot] merged 2 commits intodevelopfrom
jg/batch_decoder_force_close

Conversation

@trianglesphere
Copy link
Contributor

Description

Adds a sub-command to create force close transactions.

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

⚠️ No Changeset found

Latest commit: c03a2fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere force-pushed the jg/batch_decoder_reassemble_channels branch from 1aec27d to 220bacd Compare March 8, 2023 19:47
@trianglesphere trianglesphere force-pushed the jg/batch_decoder_force_close branch from 92638b5 to ee333fd Compare March 8, 2023 19:48
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #5075 (665f526) into develop (60129ad) will decrease coverage by 3.76%.
The diff coverage is 54.28%.

❗ Current head 665f526 differs from pull request most recent head c03a2fe. Consider uploading reports for the commit c03a2fe to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5075      +/-   ##
===========================================
- Coverage    40.78%   37.03%   -3.76%     
===========================================
  Files          354      206     -148     
  Lines        21861    17234    -4627     
  Branches       776        0     -776     
===========================================
- Hits          8917     6382    -2535     
+ Misses       12265    10218    -2047     
+ Partials       679      634      -45     
Flag Coverage Δ
bedrock-go-tests 37.03% <54.28%> (+0.46%) ⬆️
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-node/cmd/batch_decoder/main.go 0.00% <0.00%> (ø)
op-node/cmd/batch_decoder/reassemble/reassemble.go 0.00% <0.00%> (ø)
op-node/rollup/derive/channel_out.go 66.46% <86.36%> (+7.11%) ⬆️

... and 175 files with indirect coverage changes

@trianglesphere trianglesphere force-pushed the jg/batch_decoder_reassemble_channels branch from 220bacd to 41aa1e0 Compare March 10, 2023 00:23
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2023

Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Mar 10, 2023
@trianglesphere trianglesphere force-pushed the jg/batch_decoder_reassemble_channels branch 2 times, most recently from 75822d1 to 9125a14 Compare March 10, 2023 00:34
Base automatically changed from jg/batch_decoder_reassemble_channels to develop March 10, 2023 23:48
@trianglesphere trianglesphere force-pushed the jg/batch_decoder_force_close branch from ee333fd to 4c42573 Compare March 13, 2023 19:17
@mergify mergify bot removed the conflict label Mar 13, 2023
@trianglesphere trianglesphere force-pushed the jg/batch_decoder_force_close branch 4 times, most recently from b49e1b8 to 0fe6bfe Compare March 13, 2023 23:18
@trianglesphere trianglesphere marked this pull request as ready for review March 13, 2023 23:18
@trianglesphere trianglesphere requested review from a team and protolambda as code owners March 13, 2023 23:18
@trianglesphere trianglesphere changed the title batch_decoder: Force close transactions batch_decoder: Force close channels Mar 13, 2023
@trianglesphere trianglesphere force-pushed the jg/batch_decoder_force_close branch from 0fe6bfe to 665f526 Compare March 14, 2023 15:51
@netlify
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit c03a2fe
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64133efe4c636f0008cafc01

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit fc889ee into develop Mar 16, 2023
@mergify mergify bot deleted the jg/batch_decoder_force_close branch March 16, 2023 16:28
@mergify mergify bot removed the on-merge-train label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants