Conversation
🦋 Changeset detectedLatest commit: 2ef52b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
snario
reviewed
Apr 19, 2021
Contributor
|
We should consider adding some basic profiling to |
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* optimization: add back in the geohot abi caching * changeset: patch
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
missing conversions towards paradigmxyz/reth#15627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds back in geohot's optimization: ethereum-optimism/go-ethereum@8d13a77
It was recently removed but is still useful as it is still in the hot code path.
Below is a picture from the
pprofCPU profiling before these changesThis PR adds a cache to
abi.Method.IDso that each call doesn't result in a bunch of hashing and reduces the amount of time that is spent in that method significantly.It was generated with the following script on top of #477 so be sure to checkout that branch and
make gethbefore running it:Run the above script and let
gethrun for some time and thenSIGINTthe process. This will result in the generation of the filecpu.prof.Use
pprofto create an SVG that can be viewed in the browser. The following command will drop you into the interactivepprofCLI, once you are in it use thesvgcommand to generate an SVGOnce the SVG has been created,
python3can be used to serve it to the browser$ python -m http.server --bind 0.0.0.0 8080 --directory .Additional context
Need to do additional profiling to determine where the actual bottlenecks are but this was low hanging fruit