Skip to content

Comments

geth: remove dead docker code#483

Merged
tynes merged 1 commit intomasterfrom
geth/dead-docker
Apr 17, 2021
Merged

geth: remove dead docker code#483
tynes merged 1 commit intomasterfrom
geth/dead-docker

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Apr 16, 2021

Description
Removes dead code that is no longer used that was from the very first iteration of dockerizing l2geth. Reduces the diff

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2021

⚠️ No Changeset found

Latest commit: 7993679

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes tynes added A-geth C-chore Category: Code, docs or tooling maintenance labels Apr 16, 2021
@tynes tynes merged commit f04ebe8 into master Apr 17, 2021
@tynes tynes deleted the geth/dead-docker branch April 17, 2021 00:57
InoMurko referenced this pull request in omgnetwork/optimism May 25, 2021
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
theochap pushed a commit that referenced this pull request Dec 10, 2025
* fix(host): Insert empty MPT root hash

* lint
theochap pushed a commit that referenced this pull request Jan 15, 2026
hash fn is a bit of a mess rn, we have hash, hash_ref and tx_hash.

this follows the convention that hash should return a ref.

before next breaking release we should make this more consistent
emhane pushed a commit that referenced this pull request Feb 4, 2026
Part of #483.

First wait for theo's PR
[#18754](#18754) to be
merged.
Then wait for our PR
[#18772](#18772) to be
merged.

After that, in this repo, remove the current submodule and replace it
with optimism itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-chore Category: Code, docs or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants