op-node: handle when L1 time gap is larger than sequencer time drift

[protolambda]

Description

Subset of original #4758.

Handle rare case when L1 block time gap is larger than the sequencer time drift to not halt safe head.

Tests

See new unit tests to cover new sequencer time drift handling.

Invariants

• Ensure L2 time >= L1 origin time at all times
• Ensure max sequencer time drift is respected, but make exception to always preserve L1 Origin advancement and above invariant.

Additional context

See design doc.

Fix CLI-3354

[changeset-bot]

⚠️ No Changeset found

Latest commit: 48a8024

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[trianglesphere]

Adding a comment at

optimism/op-node/rollup/derive/batch_queue.go

Line 236 in b1f2812

// to preserve that L2 time >= L1 time

and in the specs to clarify that we generate empty batches past the sequencer drift until the next L1 block if there is a large gap would be helpful

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[codecov]

Codecov Report

Merging #4809 (48a8024) into develop (e636534) will decrease coverage by 4.61%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4809      +/-   ##
===========================================
- Coverage    40.44%   35.83%   -4.61%     
===========================================
  Files          323      183     -140     
  Lines        19549    15475    -4074     
  Branches       761        0     -761     
===========================================
- Hits          7906     5546    -2360     
+ Misses       11034     9359    -1675     
+ Partials       609      570      -39     

Flag	Coverage Δ
bedrock-go-tests	35.83% <100.00%> (+0.13%)	⬆️
contracts-bedrock-tests	?
contracts-tests	?
core-utils-tests	?
dtl-tests	?
fault-detector-tests	?
sdk-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
op-node/rollup/derive/batches.go	100.00% <100.00%> (+6.49%)	⬆️
...ontracts/libraries/bridge/Lib_CrossDomainUtils.sol
.../contracts-bedrock/contracts/L1/L2OutputOracle.sol
...ts-bedrock/contracts/deployment/SystemDictator.sol
.../contracts-bedrock/contracts/libraries/Hashing.sol
...bedrock/contracts/legacy/ResolvedDelegateProxy.sol
...ckages/contracts/contracts/L2/predeploys/WETH9.sol
.../contracts-bedrock/contracts/L2/L2ERC721Bridge.sol
...ntracts-bedrock/contracts/legacy/L1BlockNumber.sol
...acts-bedrock/contracts/libraries/rlp/RLPWriter.sol
... and 133 more

[protolambda]

Rebasing this now, to ensure it runs on top of latest derivation changes

[protolambda]

will rebase to fix the lint timeout issue

[mslipper]

LGTM. Proto walked me through this live, and we reviewed together.