Skip to content

feat(op-node): Add alternative backup sync method via RPC#4807

Merged
tynes merged 7 commits intodevelopfrom
clabby/op-node/alt-rpc-sync
Mar 15, 2023
Merged

feat(op-node): Add alternative backup sync method via RPC#4807
tynes merged 7 commits intodevelopfrom
clabby/op-node/alt-rpc-sync

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Jan 31, 2023 •
edited
Loading

Overview

Adds an alternative backup sync method via RPC to the op-node.

The new CLI flag, l2.backup-unsafe-sync-rpc, feeds into the new sources.L2SyncEndpointSetup, which lives in the node config. This flag is optional- if it is not present, alternative sync will not be enabled.

If the flag is set, a sources.SyncClient is initialized alongside the driver, which spawns a new event loop that the driver's state loop can communicate back and forth with in order to fetch missing blocks from a backup RPC.

Tests

  • op-e2e - TestSystemMockAltSync
  • Modified TestPayloadsQueue in the op-node to account for the PayloadsQueue changes.

Metadata

  • Closes ENG-3218

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d8a7d71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@clabby
Copy link
Contributor Author

clabby commented Jan 31, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

semgrep-app[bot]
semgrep-app bot reviewed Jan 31, 2023
View reviewed changes
@clabby clabby force-pushed the clabby/op-node/alt-rpc-sync branch 2 times, most recently from 4bbd2e2 to 6d0db76 Compare January 31, 2023 14:10
trianglesphere
trianglesphere reviewed Jan 31, 2023
View reviewed changes
trianglesphere
trianglesphere reviewed Jan 31, 2023
View reviewed changes
tynes
tynes reviewed Jan 31, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2023

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 15, 2023
@mslipper mslipper removed the Stale label Feb 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 2, 2023
@clabby clabby force-pushed the clabby/op-node/alt-rpc-sync branch from ad528e7 to d60a6c0 Compare March 2, 2023 16:14
@clabby clabby removed the Stale label Mar 2, 2023
semgrep-app[bot]
semgrep-app bot reviewed Mar 2, 2023
View reviewed changes
semgrep-app[bot]
semgrep-app bot reviewed Mar 2, 2023
View reviewed changes
semgrep-app[bot]
semgrep-app bot reviewed Mar 2, 2023
View reviewed changes
semgrep-app[bot]
semgrep-app bot reviewed Mar 2, 2023
View reviewed changes
semgrep-app[bot]
semgrep-app bot reviewed Mar 8, 2023
View reviewed changes
semgrep-app[bot]
semgrep-app bot reviewed Mar 8, 2023
View reviewed changes
@clabby clabby force-pushed the clabby/op-node/alt-rpc-sync branch from b9ab389 to d36e74b Compare March 8, 2023 19:14
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
tynes
tynes reviewed Mar 8, 2023
View reviewed changes
@clabby clabby force-pushed the clabby/op-node/alt-rpc-sync branch 8 times, most recently from f0c4ee3 to 4a6897e Compare March 15, 2023 16:08
@clabby clabby marked this pull request as ready for review March 15, 2023 16:51
@clabby clabby requested review from a team as code owners March 15, 2023 16:51
@clabby clabby requested a review from mslipper March 15, 2023 16:51
clabby added 7 commits March 15, 2023 12:52
@clabby
Init backup sync via RPC
9309f9d
@clabby
Move logic into driver loop
2a59c43
@clabby
Pull logic out of state loop; Update GetUnsafeQueueGap to return an…
5c971c0 
… exclusive (`[a, b)`) range
@clabby
Fix nil ptr dereference
9df505e
@clabby
WIP: Add SyncClient wrapper
a08fc5e
@clabby
WIP: SyncClient event loop
d6b0c35
@clabby
🧹 Squash
d8a7d71 
🧹 x2

Mark's nits pt. 1

Buffer `FetchUnsafeBlock` channel

Bump channel size

Don't rely on P2P to detect the gap; Test WIP

Resolve conflicts

Fix test

🧹, fix `op-node` PayloadQueue test after dedup change

🧹

Don't hardcode sequencer RPC port

🧹 `SystemConfig` hooks

Attempt CI fix

Force e2e setup to loop through nodes in alphabetical order

Temp: Add Kelvin's CI fix
@clabby clabby force-pushed the clabby/op-node/alt-rpc-sync branch from 4a6897e to d8a7d71 Compare March 15, 2023 16:56
protolambda
protolambda approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

Hey @clabby, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@mergify mergify bot removed the on-merge-train label Mar 15, 2023
@clabby
Copy link
Contributor Author

clabby commented Mar 15, 2023

@Mergifyio requeue

@tynes tynes merged commit 025de3d into develop Mar 15, 2023
@tynes tynes deleted the clabby/op-node/alt-rpc-sync branch March 15, 2023 20:51
@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajsutton ajsutton ajsutton left review comments

@tynes tynes tynes approved these changes

@mslipper mslipper Awaiting requested review from mslipper mslipper was automatically assigned from ethereum-optimism/infra-reviewers

+3 more reviewers

@trianglesphere trianglesphere trianglesphere left review comments

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@protolambda protolambda protolambda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@clabby @ajsutton @tynes @trianglesphere @protolambda @mslipper